Bug 8921 – Use WebCore to render full-frame images

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Anders Carlsson]

Currently this is handled by WebKit

[Anders Carlsson]

Created attachment 8325 [details]
Implement ImageDocument

[Darin Adler]

Comment on attachment 8325 [details]
Implement ImageDocument

Maciej says he's going to review this and I don't want to steal his thunder.

But I will point out that all or most of WebImageData.h/m, WebImageDecodeItem.h/m, WebImageDecoder.h/m, WebImageRenderer.h/m, and WebImageRendererFactory.h/m can be deleted too.

[Maciej Stachowiak]

I see no actual bugs, but here's a few optional style suggestions:

You could conside factoringing the first-time initialization in this function into a separate function:

+bool ImageTokenizer::writeRawData(const char *data, int len)

This could use a FIXME for things that won't work on non-Apple platforms:

+void ImageTokenizer::finish()

It might be nice to encapsulate the choice of whether to use the decoder and feed raw data a bit better than an "if" in the write function - perhaps a separate function for this, or let the tokenizer manage the decoder, or something.

+    if (Tokenizer* t = d->m_doc->tokenizer()) {

Also, as Darin mentioned, it would be nice to remove all the image support code from WebCoreSupport, now that you are removing the last use of it.

Even with all these minor comments, r=me!