Bug 8871 – REGRESSION: Pressing Enter/Return in a text input removes the selected text

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Alexey Proskuryakov]

Pressing Enter or Return in a text field when there is a selection removes the selected part (provided there's no submit button in the form).

[Alexey Proskuryakov]

Created attachment 8265 [details]
test case

[Eric Seidel (no email)]

This could be related to bug 8741

[Darin Adler]

The issue isn't whether the form has a submit button. It's whether there's a form element at all. Here's the code from HTMLInputElement::defaultEventHandler:

        } else if (clickDefaultFormButton && form()) {
            form()->submitClick();
            evt->setDefaultHandled();
        }

instead, the code should say:

        } else if (clickDefaultFormButton) {
            if (form())
                form()->submitClick();
            evt->setDefaultHandled();
        }

Whether Enter is "eaten" by the input element should not depend on whether there's a form or not.

[Adele Peterson]

I have this fix in my tree

[Alice Liu]

<rdar://problem/4575417>

[Darin Adler]

Created attachment 9450 [details]
patch with detailed change log and a layout test

[Darin Adler]

Committed revision 15454.