RESOLVED FIXED 8808
WebCore should handle text files 
https://bugs.webkit.org/show_bug.cgi?id=8808
Summary WebCore should handle text files
Anders Carlsson
Reported 2006-05-09 11:03:29 PDT
Currently, the code that handles showing text files is in WebKit and uses an NSTextView. This should be in WebCore instead
Attachments
Patch (49.50 KB, patch)
2006-05-09 11:29 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2006-05-09 11:29:43 PDT
Created attachment 8186 [details] Patch I'm not sure about whether unsupportedTextMIMETypes should be moved to WebCore...
Darin Adler
Comment 2 2006-05-09 11:35:47 PDT
Comment on attachment 8186 [details] Patch + PassRefPtr<TextDocument> createTextDocument(FrameView* v = 0); No need for the "v" there. Why create separate text nodes for each piece of data written? Maybe instead we should create just one large text node. Why create a "pre" element? Couldn't we just put the text into the body and use CSS to style as we like? +TextDocument::TextDocument(DOMImplementation *_implementation, FrameView *v) Please put * next to the type name. Please don't use an underscore prefix in new code. I do think the list of unsupported text MIME types should go into WebCore. This looks ready to go to me. r=me
Eric Seidel (no email)
Comment 3 2006-05-09 11:43:00 PDT
We also should have some test cases of text handling. These shoudl be possible with the httpd testing mechanisms.
Anders Carlsson
Comment 4 2006-05-09 12:01:16 PDT
I went ahead and committed this. I'm looking at adding test cases now.
Note You need to log in before you can comment on or make changes to this bug.