Bug 8514 - Web Inspector hides when the app is in the background
Summary: Web Inspector hides when the app is in the background
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Minor
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-21 07:26 PDT by Matt Gough
Modified: 2006-04-22 16:44 PDT (History)
0 users

See Also:


Attachments
Adds a 'Hides in Background' menu item to the Web Inspector window (1.11 KB, patch)
2006-04-21 07:29 PDT, Matt Gough
darin: review-
Details | Formatted Diff | Diff
New patch (3.53 KB, patch)
2006-04-22 16:32 PDT, Timothy Hatcher
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Gough 2006-04-21 07:26:01 PDT
Often when I am debugging my own app, I keep the same web page open in Safari with the Web Inspector open. This way I can easily inspect the same DOM that I am stepping through in the debugger. However, it is annoying that that window hides itself when Safari is not at the front as I have to keep switching between the debugger in XCode and Safari. Therefore I have created a patch which adds a 'Hides in Background' option to the pop-up menu show in the top-right corner of the Inspector.
Comment 1 Matt Gough 2006-04-21 07:29:06 PDT
Created attachment 7869 [details]
Adds a 'Hides in Background' menu item to the Web Inspector window
Comment 2 Darin Adler 2006-04-21 22:07:10 PDT
Comment on attachment 7869 [details]
Adds a 'Hides in Background' menu item to the Web Inspector window

Do we really need a menu item for this? Can't we just decide which way it should work?
Comment 3 Darin Adler 2006-04-21 22:07:51 PDT
I'm thinking it's better to just change the setting to not hide in background. We should ask Tim Hatcher what he thinks.
Comment 4 Dave Hyatt 2006-04-21 23:59:58 PDT
I personally think the default should be not to hide.  I can't stand that behavior in "debugging" windows like the Snippet Editor and the Web Inspector, since often you need to look at them while bringing another app to the front.
Comment 5 Matt Gough 2006-04-22 03:20:43 PDT
I did consider just setting it to not hide, but maybe some people like the behaviour. Personally I would default it to not hiding, but keep the menu in case people need it to for some reason. Its not as if it takes up any extra space in the UI
Comment 6 Maciej Stachowiak 2006-04-22 13:15:53 PDT
I agree that we should just change the behavior to not hide in the background. That seems better than the menu. I don't think there's a great need to offer the hiding behavior as well.
Comment 7 Darin Adler 2006-04-22 14:37:56 PDT
Comment on attachment 7869 [details]
Adds a 'Hides in Background' menu item to the Web Inspector window

We have consensus now that we want to turn hidesOnDeactivate off completely rather than adding a menu item. Also need a change log entry.
Comment 8 Timothy Hatcher 2006-04-22 16:32:56 PDT
Created attachment 7917 [details]
New patch 

Makes the inspector not hide in the background. Since the inspector is a floating panel we need to call setFloatingPanel:NO when the app is switching into the background. Then call setFloatingPanel:YES when the app is activated again. Withouth this the inspector would float above all applications.
Comment 9 Eric Seidel (no email) 2006-04-22 16:43:12 PDT
Comment on attachment 7917 [details]
New patch 

Looks fine. r=me.
Comment 10 Timothy Hatcher 2006-04-22 16:44:38 PDT
Landed in r14020.