Bug 8507 - Compilation fixes for building on gcc 4.0.2, and without precomp headers
Summary: Compilation fixes for building on gcc 4.0.2, and without precomp headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 8515
  Show dependency treegraph
 
Reported: 2006-04-20 23:29 PDT by Kevin Ollivier
Modified: 2006-04-21 23:13 PDT (History)
0 users

See Also:


Attachments
Patch for compilation fixes. (5.76 KB, patch)
2006-04-20 23:31 PDT, Kevin Ollivier
darin: review-
Details | Formatted Diff | Diff
Compilation fixes patch, with requested changes. (5.83 KB, patch)
2006-04-21 01:23 PDT, Kevin Ollivier
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Ollivier 2006-04-20 23:29:38 PDT
This patch contains the fixes needed to build JSCore and WebCore on Win/Mac/Linux without precompiled headers, as well as fixes needed for gcc 4.0.2. It also resolves two minor issues with undefined behavior on non-supported platforms, specifically defining Unicode support to use ICU in all cases outside of KDE, and defining PlatformCursor to void* when it hasn't been defined by the platform yet.
Comment 1 Kevin Ollivier 2006-04-20 23:31:09 PDT
Created attachment 7865 [details]
Patch for compilation fixes.
Comment 2 Darin Adler 2006-04-20 23:58:37 PDT
Comment on attachment 7865 [details]
Patch for compilation fixes.

Looks good. I see three problems:

    1) The include for pthread.h should be !PLATFORM(WIN_OS), not !PLATFORM(WIN)

    2) Assertions.cpp should use <stdio.h>, <stdarg.h>, and <string.h>, not "stdio.h", etc.

    3) +#elseif defined(__APPLE__)

No such thing as #elseif. It's #elif.

That issue (3) seems serious enough that we should not land it, so r-. But if you fix those 3 things, then this looks good to go.
Comment 3 Kevin Ollivier 2006-04-21 01:23:36 PDT
Created attachment 7867 [details]
Compilation fixes patch, with requested changes.
Comment 4 Kevin Ollivier 2006-04-21 01:27:05 PDT
Thanks, I've made the changes you requested. Believe it or not, #3 actually does compile with at least gcc4, which is why I didn't catch it. 
Comment 5 Darin Adler 2006-04-21 22:06:27 PDT
Comment on attachment 7867 [details]
Compilation fixes patch, with requested changes.

r=me