Bug 8445 – -[DOMHTMLSelectElement multiple] returns no when the select element is multiple

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Rachael Worthington (cheers)]

- (BOOL)multiple
{
    return ![self _selectElement]->multiple();
}

seems like a call to 'multiple' should return YES if it's multiple and not vice versa.

[Rachael Worthington (cheers)]

http://trac.webkit.org/dev/changeset/9825/trunk/WebCore/kwq/DOMHTML.mm

Looks like it was broken here, along with some other methods, when webkit switched to using a bool to keep track of it's multiple status from just checking if getAttribute(ATTR_MULTIPLE).isNull(), which DID require the inversion to be correct.

[Rob Buis]

Created attachment 8055 [details]
Proposed patch

Simple fix really. Just wondering whether there may be more wrong
replacements in objC bindings like this?
Cheers,

Rob.

[Darin Adler]

Comment on attachment 8055 [details]
Proposed patch

The long term solution for things like this is to automatically generate the Objective-C DOM bindings just as we are doing with the JavaScript bindings.

r=me