RESOLVED FIXED 8442
improvements to Cocoa bindings support in WebView - code simplification 
https://bugs.webkit.org/show_bug.cgi?id=8442
Summary improvements to Cocoa bindings support in WebView - code simplification
James G. Speth
Reported 2006-04-17 11:16:53 PDT
here are some improvements to the Cocoa bindings support in WebView from bug #8389. primarily, this removes the WebController class altogether. the WebController isn't needed anymore, since i figured out how to make the NSTreeController and WebView work well together without it. now you can just bind the contentObject binding of the tree controller directly to the mainFrameDocument key of the WebView.
Attachments
patch removing the WebController and using better simpler KVO notifications (7.39 KB, patch)
2006-04-17 14:34 PDT, James G. Speth 		no flags
DetailsFormatted DiffDiff
new patch with comments (8.08 KB, patch)
2006-04-17 18:04 PDT, James G. Speth 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2006-04-17 14:05:26 PDT
It looks like you forgot to attach the patch :(
James G. Speth
Comment 2 2006-04-17 14:34:12 PDT
Created attachment 7777 [details] patch removing the WebController and using better simpler KVO notifications
Darin Adler
Comment 3 2006-04-17 14:39:54 PDT
Comment on attachment 7777 [details] patch removing the WebController and using better simpler KVO notifications Won't removing the WebController break compatibility?
Timothy Hatcher
Comment 4 2006-04-17 15:29:33 PDT
WebController was recently added (this weekend.) It wasn't needed for any functionality, but NSTreeController workarounds. A user can just use NSTreeController with this patch.
James G. Speth
Comment 5 2006-04-17 18:04:48 PDT
Created attachment 7788 [details] new patch with comments i also moved the call to stop returning the DOMDocument from the beginning of the loading process to the point where the load is committed. it feels better this way when using it, since it's more synchronized with the WebView's state.
Timothy Hatcher
Comment 6 2006-04-18 09:48:41 PDT
Comment on attachment 7788 [details] new patch with comments This looks good. r=me
Timothy Hatcher
Comment 7 2006-04-19 19:18:53 PDT
Landed in r13980.
Note You need to log in before you can comment on or make changes to this bug.