Bug 8284 - prevent unnecessary entries in the "nodes with extra refs" hash table
Summary: prevent unnecessary entries in the "nodes with extra refs" hash table
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-09 21:48 PDT by Geoffrey Garen
Modified: 2006-04-09 22:02 PDT (History)
0 users

See Also:


Attachments
Fix (6.09 KB, patch)
2006-04-09 21:49 PDT, Geoffrey Garen
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2006-04-09 21:48:05 PDT
There's a unique cost to incrementing a node's ref count past one. If we use RefPtr::release instead of regular assignment, we can't keep the ref count at 1, and never pay the cost.
Comment 1 Geoffrey Garen 2006-04-09 21:49:55 PDT
Created attachment 7609 [details]
Fix
Comment 2 Geoffrey Garen 2006-04-09 21:50:28 PDT
s/can't/can/ in the original description
Comment 3 Eric Seidel (no email) 2006-04-09 21:51:48 PDT
Comment on attachment 7609 [details]
Fix

Looks great.  r=me.
Comment 4 Geoffrey Garen 2006-04-09 22:02:55 PDT
Landed.