Bug 8145 – REGRESSION: Pasting text from TextEdit with a bold word into text field results in crash

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Mark Rowe (bdash)]

Steps to reproduce:
1) Open TextEdit
2) Type a few words of text
3) Select a word and make it bold
4) Copy all of the text
5) Open http://www.google.com/ and paste the text into the search field
6) <crash>

The crash log is attached.

[Mark Rowe (bdash)]

Created attachment 7470 [details]
Crash log.

[Darin Adler]

Crash happens because a node is nil. This happens because of this code in ReplaceSelectionCommand::doApply:

702             } else if (m_lastNodeInserted && !m_fragment.isBlockFlow(refNode)) {
703                 Position pos = visiblePos.next().deepEquivalent().downstream();
704                 insertNodeAtAndUpdateNodesInserted(refNode, pos.node(), pos.offset());

visiblePos.next() is null.

[Mark Rowe (bdash)]

Created attachment 7471 [details]
Rough patch

The patch simply adds a NULL check before the call to insertNodeAtAndUpdateNodesInserted.  I don't really understand the code in question so I am in no way confident that it is the right fix, however it prevents the crash and doesn't appear to change any other behaviour.

[Darin Adler]

Comment on attachment 7471 [details]
Rough patch

I believe this is wrong and will result in the pasted text not being inserted at all!

The right thing is to find a way to insert after visiblePos instead of before visiblePos.next() in this case.

[Darin Adler]

Justin should probably handle this one himself.

[Mark Rowe (bdash)]

The pasted text is definitely inserted correctly with that patch, but I'm more than willing to let Justin handle this.

[Maciej Stachowiak]

These are all text field regressions so they should all be P1.

[Darin Adler]

*** Bug 8149 has been marked as a duplicate of this bug. ***

[Darin Adler]

Same as <rdar://problem/4499431>.

[Justin Garcia]

Created attachment 7545 [details]
patch, changelog and layout tests

[Justin Garcia]

Created attachment 7546 [details]
patch, changelog and layout tests

[Justin Garcia]

Comment on attachment 7546 [details]
patch, changelog and layout tests

dave reviewed this in person, and he's going to look it over and do a final review tonight.

[Justin Garcia]

Created attachment 7552 [details]
patch, changelog and layout tests

One more revision of my changelog and code comments.

[Justin Garcia]

Comment on attachment 7552 [details]
patch, changelog and layout tests

dave reviewed this