Bug 8112 - Wrong calculation of min/max values for time_t
Summary: Wrong calculation of min/max values for time_t
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 3356
  Show dependency tree / graph
 
Reported: 2006-03-31 16:03 PST by Björn Graf (boki)
Modified: 2007-09-30 11:01 PDT (History)
3 users (show)

See Also:

Attachments
Adds _USE_32BIT_TIME_T to the projects preprocessor definitions (5.34 KB, patch)
2006-03-31 16:08 PST, Björn Graf (boki) 		ggaren: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Graf (boki) 2006-03-31 16:03:02 PST 
In VC++ 2005 time_t defaults to time64_t which causes the calculation of the minimum and maximum values in millisecondsToTM to exceed _MAX_TIME64. A naive fix is to define _USE_32BIT_TIME_T.
Comment 1 Björn Graf (boki) 2006-03-31 16:08:22 PST 
Created attachment 7426 [details]
Adds _USE_32BIT_TIME_T to the projects preprocessor definitions

This patch also changes the lib output directory to $(WebKitOutputDir)\$(ConfigurationName) and updates testkjs.vcproj to use the lib from that location. Winmm.lib is added for an upcoming StopWatch fix.
Comment 2 Geoffrey Garen 2006-03-31 16:18:46 PST 
Comment on attachment 7426 [details]
Adds _USE_32BIT_TIME_T to the projects preprocessor definitions

Looks good. r=me
Comment 3 Eric Seidel (no email) 2006-04-04 04:58:42 PDT 
This doesn't include a changelog entry and doesn't update the WebCore, ImageViewer or Spinneret targets, thus making it much harder to land.  I'd rather you post a second patch instead.
Comment 4 Geoffrey Garen 2006-04-26 11:35:31 PDT 
Comment on attachment 7426 [details]
Adds _USE_32BIT_TIME_T to the projects preprocessor definitions

Based on Eric's comments, I'm changing this to r-.
Comment 5 Eric Seidel (no email) 2007-09-30 11:01:42 PDT 
This bug has been stale for over a year.   The windows port works. :)  Closing.