Bug 8044 – WebKit Visual Studio 2005 project shouldn't use the SolutionDir

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Justin Haygood]

The paths should be relative to the projectdir.. so that the projects can be added to other solutions without breaking anything

[Justin Haygood]

Created attachment 7365 [details]
Makes projects use project directory

[Justin Haygood]

From #webkit:

[20:02] <boki> just curious: what's the benefit of that?
[20:03] <jhaygood> I have one big uber solution that has all of the webkit stuff in it
[20:03] <jhaygood> and thus the solutiondir is dift
[20:03] <jhaygood> the big solution makes it so that modifying webcore for instance makes spinneret realize it should relink
[20:03] <jhaygood> and so I don't need multiple VS2005 instances open
[20:04] <boki> might be worth to mention that in the bug :)

[Darin Adler]

Comment on attachment 7365 [details]
Makes projects use project directory

Seems fine. Being relative to the project at all is probably wrong for the long term, but this makes us less dependent on the solution structure, which is nice.

Please don't use tabs in your ChangeLog files though. We can't commit them with tabs and it just makes extra work for whoever lands the patch.

[Eric Seidel (no email)]

This is a great fix.  However it woudl be even better if it were pasted as a perl script as I'm not sure this still will apply cleanly.

[Justin Haygood]

I'm not good enough with Perl to write a script to do that...

But, if someone else wants to:

change:
$(SolutionDir)
to:
$(ProjectDir)\..

[Geoffrey Garen]

[phone]  Geoffrey Garen  <[e-mail]>
+
+        Reviewed by Darin.
+
+        Committing the project file change jhaygood suggesed in
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=8044
+        WebKit Visual Studio 2005 project shouldn't use the SolutionDir
+        
+        Instead of his patch, I used the following commands:
+
+        sed -e 's/$(SolutionDir)/$(ProjectDir)\\../g' Image\ Viewer/Image\
+        Viewer.vcproj > Image\ Viewer/Image\ Viewer.vcproj_ && mv Image\
+        Viewer/Image\ Viewer.vcproj_ Image\ Viewer/Image\ Viewer.vcproj
+
+        sed -e 's/$(SolutionDir)/$(ProjectDir)\\../g'
+        WebCore/WebCore.vcproj > WebCore/WebCore.vcproj_ && mv
+        WebCore/WebCore.vcproj_ WebCore/WebCore.vcproj
+
+        * Viewer.vcproj:
+        * WebCore.vcproj/WebCore/WebCore.vcproj:
+