Bug 8029 - Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
Summary: Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Justin Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-28 04:12 PST by Justin Garcia
Modified: 2006-09-26 11:34 PDT (History)
1 user (show)

See Also:

Attachments
patch (28.16 KB, patch)
2006-09-22 14:07 PDT, Justin Garcia 		justin.garcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2006-03-28 04:12:55 PST 
isDescendantOf is what AppKit uses for subviews and superviews, and it's much more readable than isAncestor.
Comment 1 Justin Garcia 2006-09-22 14:07:25 PDT 
Created attachment 10716 [details]
patch
Comment 2 Darin Adler 2006-09-22 16:33:57 PDT 
Comment on attachment 10716 [details]
patch

I thought we were going to use the name "hasAncestor".
Comment 3 Justin Garcia 2006-09-22 17:14:39 PDT 
Comment on attachment 10716 [details]
patch

darin&i fought over this and i won