WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
7947
Add repaint testing support to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=7947
Summary
Add repaint testing support to run-webkit-tests
mitz
Reported
2006-03-23 16:13:57 PST
[This is different from
bug 6905
] By forcing WebCore to paint one line or column of pixels at a time, it is possible to detect objects that do not repaint correctly and to automate tests for repaint bugs. Just by running in this mode over some of the existing tests I spotted two repaint bugs. I am going to attach a patch to DRT and run-webkit-tests that adds this test mode both as an option to run-webkit-tests (to use on existing tests) and as a layoutTestController option (to be used by repaint regression tests). Unfortunately, as I have found out today, when sweeping vertically, almost every test fails to repaint correctly, since Times paints one line of faint pixels above the line rect (the problem of fonts painting outside their line bounds is known, see
bug 6274
). Still, I think the option is useful, at least for automating repaint tests.
Attachments
Patch
(6.02 KB, patch)
2006-03-23 16:18 PST
,
mitz
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
mitz
Comment 1
2006-03-23 16:18:22 PST
Created
attachment 7265
[details]
Patch
Darin Adler
Comment 2
2006-03-23 16:49:27 PST
Comment on
attachment 7265
[details]
Patch Looks really cool. r=me
Eric Seidel (no email)
Comment 3
2006-03-25 14:21:24 PST
Landed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug