Bug 7907 – Replace more uses of DeprecatedString with String

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Eric Seidel (no email)]

Replace more uses of DeprecatedString with String

This all started when I went to fix bug 7884 (before feeling sick and then sleeping for 16 hours straight).

[Eric Seidel (no email)]

Created attachment 7227 [details]
Replace more uses of DeprecatedString with String

[Eric Seidel (no email)]

Created attachment 7228 [details]
Remove a few more DeprecatedString uses while I'm at it...

[Darin Adler]

Comment on attachment 7228 [details]
Remove a few more DeprecatedString uses while I'm at it...

+    if (s.isEmpty())
+        return String(cs);

You don't need all these isEmpty checks. The String + operator already handles them; an additional check doesn't add value.

The AccessibilityObjectCache changes are going to collide with my near-complete rewrite of that file due to fixing it for Garbage Collection (and yes, I had removed use of DeprecatedString).

I'm not sure about the "get values directly from settings" change. It's a nice simplification. But it means that some settings that used to stay the same until location change will now be "live". That means you could start loading a page with JavaScript disabled and then later have it enabled or vice versa. I believe that can lead to problems, although I'm not certain. Since you're changing the semantics you will need to test.

r=me, assuming you test the settings change in Frame

[Eric Seidel (no email)]

I made darin's suggested modifications and landed.