RESOLVED FIXED 7882
Remove more DeprecatedString usage 
https://bugs.webkit.org/show_bug.cgi?id=7882
Summary Remove more DeprecatedString usage
Eric Seidel (no email)
Reported 2006-03-20 17:08:53 PST
Remove more DeprecatedString usage.... it's existance bothers me greatly ;)
Attachments
Remove more DeprecatedString (65.17 KB, patch)
2006-03-20 17:10 PST, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
Same patch as above, ignoring whitespace (19.61 KB, patch)
2006-03-20 17:10 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2006-03-20 17:09:35 PST
its even.
Eric Seidel (no email)
Comment 2 2006-03-20 17:10:00 PST
Created attachment 7201 [details] Remove more DeprecatedString
Eric Seidel (no email)
Comment 3 2006-03-20 17:10:45 PST
Created attachment 7202 [details] Same patch as above, ignoring whitespace
Darin Adler
Comment 4 2006-03-22 08:07:59 PST
Comment on attachment 7201 [details] Remove more DeprecatedString - kdDebug( 6080 ) << "CSSParser::CSSParser this=" << this << endl; + kdDebug(6080) << "CSSParser::CSSParser this=" << this << endl; - kdDebug( 6080 ) << "CSS parse error " << str << endl; + kdDebug(6080) << "CSS parse error " << str << endl; We don't even have kdDebug in our tree, so this should be removed rather than reformatted. There's a ton in this patch that has nothing to do with DeprecatedString. - valid_primitive = ( validUnit( value, FLength, strict ) ); + valid_primitive = (validUnit(value, FLength, strict)); I suggest removing the parentheses altogether here. + // qDebug(" new value: id=%d", id); -// kdDebug( 6080 ) << " got style, variant and weight current=" << valueList->currentValue << endl; +// kdDebug(6080) << " got style, variant and weight current=" << valueList->currentValue << endl; - // kdDebug( 6080 ) << " got size" << endl; + // kdDebug(6080) << " got size" << endl; + //qDebug("value = %s, converted=%.2f", DeprecatedString((QChar *)t, length).latin1(), yylval->val); Lets remove commented-out debugging code too.
Note You need to log in before you can comment on or make changes to this bug.