Bug 7802 – devenv.com not available in VC++ Express installations

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Björn Graf (boki)]

webkitdirs.pm uses devenv.com to build the projects on windows, but devenv.com is not available when using the Express version of VC++. Using vcbuild.exe instead is a better choice as it is installed with both, the full VS.NET and the Express version.

[Björn Graf (boki)]

Created attachment 7111 [details]
Utilize vcbuild.exe in webkit.pm

[Björn Graf (boki)]

Created attachment 7124 [details]
Utilize vcbuild.exe in webkit.pm with VCINSTALLDIR check

[Darin Adler]

Comment on attachment 7124 [details]
Utilize vcbuild.exe in webkit.pm with VCINSTALLDIR check

If this works, we should definitely do it! But I don't have a Windows machine to test on.

[Maciej Stachowiak]

Comment on attachment 7124 [details]
Utilize vcbuild.exe in webkit.pm with VCINSTALLDIR check

r=me but whoever lands this should test on windows to make sure it works ok with full VC

[Darin Adler]

*** Bug 7871 has been marked as a duplicate of this bug. ***

[David Kilzer (:ddkilzer)]

Committed revision 15015.

Watching buildbot for Windows build errors.  http://build.webkit.org/

[David Kilzer (:ddkilzer)]

This patch did not work on the buildbot.

http://build.webkit.org/post-commit-win32/builds/1746/step-compile-release/0

Looks like vcvars32.bat needs to be run on the buildbot.  Hyatt, can you do this, or is this something that needs to be done every time the user logs in?

Run "<Program Files>\Microsoft Visual Studio 8\VC\bin\vcvars32.bat" to set VC variables at /cygdrive/c/WebKit-BuildSlave/post-commit-win32/build/WebKitTools/Scripts/webkitdirs.pm line 350.
program finished with exit code 2

I am backing out the patch for now.

[David Kilzer (:ddkilzer)]

Created attachment 9007 [details]
Updated patch with ChangeLog 

If the vcvars32.bat script gets run on the Win32 buildbot, this patch may work again.

[David Kilzer (:ddkilzer)]

(In reply to comment #8)
> Created an attachment (id=9007) [edit]
> Updated patch with ChangeLog 

I did not change anything in the patch itself, but the original patch applied with fuzz 1.

[David Kilzer (:ddkilzer)]

Created attachment 9008 [details]
Patch with no reviewer set

Same as previous patch, but no reviewer set.  *sigh*

[Darin Adler]

(In reply to comment #10)
> Same as previous patch, but no reviewer set.  *sigh*

The reason this had Maciej as a reviewer is that he long since said "r=me" (see comment #4 above).

But we need someone to test that this works on a system with Visual Studio before we land it. Sorry it's been sitting around so long.

[David Kilzer (:ddkilzer)]

(In reply to comment #11)
> (In reply to comment #10)
> > Same as previous patch, but no reviewer set.  *sigh*
> 
> The reason this had Maciej as a reviewer is that he long since said "r=me" (see
> comment #4 above).

Actually, I was sighing at myself because I forgot to clear Maciej from previous patch as the reviewer before uploading it to this bug.  :)

As soon as this lands, I'll install VC++ Express on my Windows laptop so I can play with WebKit there, too.

[Maciej Stachowiak]

This forces people with full visual studio to set VCINSTALLDIR, which hasn't been a requirement before. Probably it could just default to using "$programFilesPath/Microsoft Visual Studio 8/VC/" instead of VCINSTALLDIR if its not set, but r- for the technicality.

[Björn Graf (boki)]

Created attachment 9189 [details]
Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set

[David Kilzer (:ddkilzer)]

Committed revision 15252.

Hopefully, the buildbot won't break this time.  :)

[David Kilzer (:ddkilzer)]

(In reply to comment #15)
> Committed revision 15252.
> 
> Hopefully, the buildbot won't break this time.  :)

No such luck.   Attempted one build-fix in r15254.

[David Kilzer (:ddkilzer)]

(In reply to comment #16)
> (In reply to comment #15)
> > Committed revision 15252.
> > Hopefully, the buildbot won't break this time.  :)
> No such luck.   Attempted one build-fix in r15254.

Okay, that worked.  If VC++ Express still isn't working, please open a new bug and file a new patch.  Thanks!  :)

[David Kilzer (:ddkilzer)]

Created attachment 9298 [details]
Final build fix patch

[David Kilzer (:ddkilzer)]

Reopening once again.  This broke the Windows buildbot yet again.  Will mark the patches r-.

[Alexey Proskuryakov]

Created attachment 11333 [details]
another attempt

Updates the earlier patches to use VCExpress.exe, which takes the same parameters as devenv.com.

Unfortunately, VCExpress.exe doesn't print anything to the console, saving its results to per-project HTML files. Still, this is hopefully slightly better than the current situation (and I suppose that everyone builds from VC Express IDE anyway).

Cmake apparently has a workaround, but I couldn't make it work: <http://www.cmake.org/pipermail/cmake/2006-February/008292.html>.

[Maciej Stachowiak]

Comment on attachment 11333 [details]
another attempt

r=me

[Anders Carlsson]

Committed revision 17551.