Bug 7745 - charAt layout test fails on intel macs; some NaNs are printed as -NaN
Summary: charAt layout test fails on intel macs; some NaNs are printed as -NaN
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-12 18:11 PST by Maciej Stachowiak
Modified: 2006-03-17 14:00 PST (History)
0 users

See Also:


Attachments
don't ever convert a NaN to a string as "-NaN" (1022 bytes, patch)
2006-03-12 18:14 PST, Maciej Stachowiak
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2006-03-12 18:11:42 PST
LayoutTests/fast/js/char-at.html fails on intel macs, some of the NaN values print as -NaN. According to the ECMA-262 specification there should be no such thing as -NaN and indeed, other browsers print all NaN values as NaN. Converting to string is the only way to observe the difference, so fixing the string conversion is enough to fix the problem.
Comment 1 Maciej Stachowiak 2006-03-12 18:14:35 PST
Created attachment 7038 [details]
don't ever convert a NaN to a string as "-NaN"
Comment 2 Darin Adler 2006-03-12 20:44:41 PST
Comment on attachment 7038 [details]
don't ever convert a NaN to a string as "-NaN"

Looks fine. r=me