Bug 7718 – run-webkit-tests fast/dom/HTMLObjectElement/ hangs

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Alexey Proskuryakov]

run-webkit-tests fast/dom/HTMLObjectElement/

This runs two tests, each of those runs fine on its own. Here, object-as-frame.html hangs while waiting for notifyDone(), because an exception happens earlier:

ReferenceError: Can't find variable: shouldBe

This seems to indicate that onLoad is called before external scripts are loaded.

[Darin Adler]

Maybe this is the reason some layout tests intermittently fail on the server. Those also seem to indicate that onload is firing before scripts run, although they are internal scripts, not external.

It's all about the trailing slash. This hangs:
run-webkit-tests fast/dom/HTMLObjectElement//object-as-frame.html
but this doesn't:
run-webkit-tests fast/dom/HTMLObjectElement/object-as-frame.html

[Alexey Proskuryakov]

Created attachment 7048 [details]
proposed fix

Mitz has explained it to me that sequences of slashes don't collapse in URLs (unlike they do in POSIX paths), so just patching run-webkit-tests.

[Alexey Proskuryakov]

DumpRenderTree uses CFURLCreateWithFileSystemPath() for file paths, and it sounds like this function should canonicalize the paths; <rdar://4475631>.

[David Kilzer (:ddkilzer)]

Comment on attachment 7048 [details]
proposed fix

>-        print OUT "$testPath\n";
>+        print OUT File::Spec->canonpath("$testPath\n");

I don't think the "\n" should be included in the method call since it's not part of the path!  Something more like this:

>+        print OUT File::Spec->canonpath($testPath), "\n";

[Alexey Proskuryakov]

Created attachment 7049 [details]
proposed fix

I don't think it changes the behavior in any way, but if it reads better, why not :)

[Darin Adler]

Comment on attachment 7049 [details]
proposed fix

r=me