Bug 77160 - SchemeRegistry scheme registration is racey
Summary: SchemeRegistry scheme registration is racey
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cris Neckar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-26 16:24 PST by Cris Neckar
Modified: 2013-03-16 22:54 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2012-01-26 16:44 PST, Cris Neckar 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cris Neckar 2012-01-26 16:24:57 PST 
Scheme registration within SchemeRegistry should only be able to occur from the main thread as pointed out by ap@ on https://bugs.webkit.org/show_bug.cgi?id=77041. Currently this is not enforced and in some cases this may cause a race.

We should fix this and add asserts (as AP suggested) to all of the scheme registries.
Comment 1 Cris Neckar 2012-01-26 16:44:27 PST 
Created attachment 124213 [details]
Patch
Comment 2 Adam Barth 2012-01-26 16:46:30 PST 
Comment on attachment 124213 [details]
Patch

WebKit usually prefers links to bugs rather than parenthetical comments.  (We're lazy that way.)
Comment 3 Cris Neckar 2012-01-26 16:54:43 PST 
Committed r106064: <http://trac.webkit.org/changeset/106064>
Comment 4 Cris Neckar 2012-01-26 16:57:42 PST 
This patch was just to remove the assert and add a fixme
Comment 5 Alexey Proskuryakov 2013-03-16 22:54:30 PDT 
Comment on attachment 124213 [details]
Patch

Clearing r+ flag from a landed patch, so that this doesn't show up in commit queue.