RESOLVED FIXED 7692
Should use an iterator in CompositeEditCommand::doUnapply() 
https://bugs.webkit.org/show_bug.cgi?id=7692
Summary Should use an iterator in CompositeEditCommand::doUnapply()
Justin Garcia
Reported 2006-03-09 21:49:48 PST
About 25% of the time during an Undo is spent getting the ith EditCommand out of m_cmds: for (int i = m_cmds.count() - 1; i >= 0; --i) m_cmds[i]->unapply(); We should use an iterator.
Attachments
patch (892 bytes, patch)
2006-03-09 21:57 PST, Justin Garcia 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Garcia
Comment 1 2006-03-09 21:57:08 PST
Created attachment 6974 [details] patch
Adele Peterson
Comment 2 2006-03-09 22:38:08 PST
Comment on attachment 6974 [details] patch Assuming all tests pass, r=me.
Note You need to log in before you can comment on or make changes to this bug.