Bug 7616 - get all references to KJS::Node out of internal.h
Summary: get all references to KJS::Node out of internal.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-05 11:51 PST by Darin Adler
Modified: 2006-03-05 21:54 PST (History)
0 users

See Also:


Attachments
patch with change log (49.96 KB, patch)
2006-03-05 11:53 PST, Darin Adler
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2006-03-05 11:51:34 PST
While working on removing the "Impl" suffix from class names in WebCore, I discovered a conflict between KJS::Node and WebCore::Node. This happens because KJS::Node is exposed to WebCore. But it should not be.

The best fix would be to not use "internal.h" at all in WebCore. This is impractical at the moment because it's used for a number of different reasons.

Instead, I factored out the only thing in "internal.h" that needs KJS::Node out into a separate file. It's the parser, and the new file is "Parser.h". This fits with our future direction for JavaScriptCore of naming files after the classes in them.
Comment 1 Darin Adler 2006-03-05 11:53:54 PST
Created attachment 6875 [details]
patch with change log