Bug 7491 - add new TextEncoding stuff to win32 build
Summary: add new TextEncoding stuff to win32 build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-27 03:02 PST by Maciej Stachowiak
Modified: 2006-02-27 13:54 PST (History)
0 users

See Also:


Attachments
Add TextEncoding, plus some fixes (146.39 KB, patch)
2006-02-27 03:04 PST, Maciej Stachowiak
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2006-02-27 03:02:54 PST
add new TextEncoding stuff to win32 build

This fixes 7 link errors. There are still two left that seem fairly encoding-related, for converting from utf-16 to a specified encoding. That is because we use CF for encoding.
Comment 1 Maciej Stachowiak 2006-02-27 03:04:13 PST
Created attachment 6758 [details]
Add TextEncoding, plus some fixes
Comment 2 Darin Adler 2006-02-27 08:19:53 PST
Comment on attachment 6758 [details]
Add TextEncoding, plus some fixes

std::min is in <algorithm>, so you should include that instead of <utility> in StreamingTextDecoder.cpp.

It worries me that the entire WebCore.vcproj is showing up in the diff. Is something configured wrong in Subversion?