Bug 7397 - TCPageMap.h would not compile for me because string.h was missing
Summary: TCPageMap.h would not compile for me because string.h was missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-20 17:54 PST by Michael Emmel
Modified: 2006-02-21 09:01 PST (History)
0 users

See Also:


Attachments
patch (336 bytes, patch)
2006-02-20 22:32 PST, Joost de Valk (AlthA)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Emmel 2006-02-20 17:54:39 PST
TCPageMap.h would not compile for me because string.h was missing thus
not picking up memset


Index: JavaScriptCore/kxmlcore/TCPageMap.h
===================================================================
--- JavaScriptCore/kxmlcore/TCPageMap.h (revision 12896)
+++ JavaScriptCore/kxmlcore/TCPageMap.h (working copy)
@@ -53,6 +53,7 @@
 #else
 #include <sys/types.h>
 #endif

+#include <string.h>

 #include "kxmlcore/Assertions.h"
Comment 1 Joost de Valk (AlthA) 2006-02-20 22:30:33 PST
Hi Reporter, 

i've seen this thread on the mailinglist, but the proper procedure here would be to tell in the summary of the bugreport what is failing for you, and then add the patch to this as an attachment, setting a "review ?" flag on it.

I'll do this for you for now :)
Comment 2 Joost de Valk (AlthA) 2006-02-20 22:32:19 PST
Created attachment 6636 [details]
patch

As said above.
Comment 3 Darin Adler 2006-02-20 23:07:08 PST
Comment on attachment 6636 [details]
patch

Looks fine, r=me.