WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
7397
TCPageMap.h would not compile for me because string.h was missing
https://bugs.webkit.org/show_bug.cgi?id=7397
Summary
TCPageMap.h would not compile for me because string.h was missing
Michael Emmel
Reported
2006-02-20 17:54:39 PST
TCPageMap.h would not compile for me because string.h was missing thus not picking up memset Index: JavaScriptCore/kxmlcore/TCPageMap.h =================================================================== --- JavaScriptCore/kxmlcore/TCPageMap.h (revision 12896) +++ JavaScriptCore/kxmlcore/TCPageMap.h (working copy) @@ -53,6 +53,7 @@ #else #include <sys/types.h> #endif +#include <string.h> #include "kxmlcore/Assertions.h"
Attachments
patch
(336 bytes, patch)
2006-02-20 22:32 PST
,
Joost de Valk (AlthA)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joost de Valk (AlthA)
Comment 1
2006-02-20 22:30:33 PST
Hi Reporter, i've seen this thread on the mailinglist, but the proper procedure here would be to tell in the summary of the bugreport what is failing for you, and then add the patch to this as an attachment, setting a "review ?" flag on it. I'll do this for you for now :)
Joost de Valk (AlthA)
Comment 2
2006-02-20 22:32:19 PST
Created
attachment 6636
[details]
patch As said above.
Darin Adler
Comment 3
2006-02-20 23:07:08 PST
Comment on
attachment 6636
[details]
patch Looks fine, r=me.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug