we should set up new platform test macros so you can do this: // operating system #if PLATFORM(DARWIN) #if PLATFORM(WIN_OS) #if PLATFORM(POSIX) // graphics library #if PLATFORM(CG) #if PLATFORM(CAIRO) // desktop environment / toolkit #if PLATFORM(MAC) // (or should that be AQUA or QUARTZ?) #if PLATFORM(KDE) #if PLATFORM(WIN) These would expand to defined(PLATFORM_FOO) and the PLATFORM_FOO macros would be predefined as appropriate. could also set it up so you can do things like #if FEATURE(HAVE_STRCASECMP) or even #if HAVE(STRCASECMP)
Created attachment 6797 [details] patch to add platform test macros
Comment on attachment 6797 [details] patch to add platform test macros +#ifndef PLATFORM(WIN_OS) That should be #if ! Otherwise looks fine. r=me Please don't land the partial checkout.html change here.
Maciej landed this last night.