Bug 7345 - add insert and remove functions to KXMLCore::Vector
Summary: add insert and remove functions to KXMLCore::Vector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Enhancement
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 7331
  Show dependency treegraph
 
Reported: 2006-02-18 14:46 PST by Darin Adler
Modified: 2006-02-18 15:45 PST (History)
0 users

See Also:


Attachments
implementation of insert and remove (4.53 KB, patch)
2006-02-18 14:48 PST, Darin Adler
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2006-02-18 14:46:30 PST
I came across yet another place where I needed insert and remove in a vector, so I wrote them as discussed with Maciej previously.
Comment 1 Darin Adler 2006-02-18 14:48:21 PST
Created attachment 6591 [details]
implementation of insert and remove
Comment 2 Maciej Stachowiak 2006-02-18 15:02:58 PST
Comment on attachment 6591 [details]
implementation of insert and remove

The ASSERT in remove() should be <, not <=. Other than that, r=me.