Bug 7125 - remove frame, renderer and completed flag from ChildFrame, make Frame track these
Summary: remove frame, renderer and completed flag from ChildFrame, make Frame track t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-06 23:31 PST by Maciej Stachowiak
Modified: 2006-02-08 10:37 PST (History)
2 users (show)

See Also:


Attachments
the patch (39.62 KB, patch)
2006-02-07 00:03 PST, Maciej Stachowiak
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2006-02-06 23:31:23 PST
This patch removes pretty much all remaining interesting content from ChildFrame, and splits frames and plugins more thoroughly. <object> tags containing html now act more like frames.
Comment 1 Maciej Stachowiak 2006-02-07 00:03:23 PST
Created attachment 6319 [details]
the patch
Comment 2 Maciej Stachowiak 2006-02-07 01:00:52 PST
Comment on attachment 6319 [details]
the patch

Eric reviewed this.
Comment 3 Alexey Proskuryakov 2006-02-07 10:34:08 PST
fast/dom/HTMLObjectElement/object-as-frame.html fails for me:

-PASS window.frames[1].location.toString() is "data:text/html,Updated contents of object"
+FAIL window.frames[1].location.toString() should be data:text/html,Updated contents of object. Was data:text/html,New contents of frame

LEAK: 51 RenderObject
LEAK: 63 NodeImpl
LEAK: 3 Frame
LEAK: 526 KJS::Node

Not reopening, because the bug was not closed yet, even though the patch has been landed.
Comment 4 mitz 2006-02-07 23:03:23 PST
(In reply to comment #3)
> fast/dom/HTMLObjectElement/object-as-frame.html fails for me:
> 
> -PASS window.frames[1].location.toString() is "data:text/html,Updated contents
> of object"
> +FAIL window.frames[1].location.toString() should be data:text/html,Updated
> contents of object. Was data:text/html,New contents of frame

I can confirm that the test is failing as of r12654, but as Alexey said on IRC, only on a dual-processor machine with both processors enabled. If I disable one of the processors, the test passes.
Comment 5 Maciej Stachowiak 2006-02-07 23:29:43 PST
Only fails on dual processors - that means a likely race condition.
Comment 6 Alexey Proskuryakov 2006-02-08 10:37:48 PST
Opened bug 7142 to track the test failure.