RESOLVED FIXED 7125
remove frame, renderer and completed flag from ChildFrame, make Frame track these 
https://bugs.webkit.org/show_bug.cgi?id=7125
Summary remove frame, renderer and completed flag from ChildFrame, make Frame track t...
Maciej Stachowiak
Reported 2006-02-06 23:31:23 PST
This patch removes pretty much all remaining interesting content from ChildFrame, and splits frames and plugins more thoroughly. <object> tags containing html now act more like frames.
Attachments
the patch (39.62 KB, patch)
2006-02-07 00:03 PST, Maciej Stachowiak 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2006-02-07 00:03:23 PST
Created attachment 6319 [details] the patch
Maciej Stachowiak
Comment 2 2006-02-07 01:00:52 PST
Comment on attachment 6319 [details] the patch Eric reviewed this.
Alexey Proskuryakov
Comment 3 2006-02-07 10:34:08 PST
fast/dom/HTMLObjectElement/object-as-frame.html fails for me: -PASS window.frames[1].location.toString() is "data:text/html,Updated contents of object" +FAIL window.frames[1].location.toString() should be data:text/html,Updated contents of object. Was data:text/html,New contents of frame LEAK: 51 RenderObject LEAK: 63 NodeImpl LEAK: 3 Frame LEAK: 526 KJS::Node Not reopening, because the bug was not closed yet, even though the patch has been landed.
mitz
Comment 4 2006-02-07 23:03:23 PST
(In reply to comment #3) > fast/dom/HTMLObjectElement/object-as-frame.html fails for me: > > -PASS window.frames[1].location.toString() is "data:text/html,Updated contents > of object" > +FAIL window.frames[1].location.toString() should be data:text/html,Updated > contents of object. Was data:text/html,New contents of frame I can confirm that the test is failing as of r12654, but as Alexey said on IRC, only on a dual-processor machine with both processors enabled. If I disable one of the processors, the test passes.
Maciej Stachowiak
Comment 5 2006-02-07 23:29:43 PST
Only fails on dual processors - that means a likely race condition.
Alexey Proskuryakov
Comment 6 2006-02-08 10:37:48 PST
Opened bug 7142 to track the test failure.
Note You need to log in before you can comment on or make changes to this bug.