Bug 7071 – REGRESSION: Jumping to an anchor identifier makes page scroll horizontally

• Status: VERIFIED
• Resolution: FIXED
• Component: DOM

[David Kilzer (:ddkilzer)]

Clicking on a '#name' link where the <a name="name"></a> tag is offset from the left side of the page causes the page to scroll to the right (assuming content on the page is wider than the visible area).

This is a regression from Safari 2.0.3 (417.8) in 10.4.4.  Test with ToT on revision r12557.

[David Kilzer (:ddkilzer)]

Created attachment 6252 [details]
Test case

[David Kilzer (:ddkilzer)]

Neither Firefox 1.5.0.1 nor MSIE 6 jump to the right using the test case (Attachment 6252 [details]).

[David Kilzer (:ddkilzer)]

Doing a binary search of nightly builds, the regression occurred here:

    Broken: WebKit-SVN-r12476.dmg Mon Jan 30 10:04:50 GMT 2006
Not broken: WebKit-SVN-r12467.dmg Mon Jan 30 4:45:53 GMT 2006

[Darin Adler]

My first guess would be that I broke this when doing my cleanup of Int/Float-Size/Point/Rect classes.

[Darin Adler]

Yes, I caused this problem by changing the definition of what the intersection function does for empty rectangles. Empty intersections now return a completely empty rectangle, but getRectToExpose depends on the old behavior where the X and Y intersections were separate.

[Darin Adler]

Created attachment 6259 [details]
patch to fix the problem, including change log and test

[Adele Peterson]

Comment on attachment 6259 [details]
patch to fix the problem, including change log and test

looks good. r=me

[David Kilzer (:ddkilzer)]

Verified fixed!