Bug 6988 - REGRESSION: Display correct context menus for new text fields
Summary: REGRESSION: Display correct context menus for new text fields
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Adele Peterson
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2006-01-31 18:57 PST by Adele Peterson
Modified: 2006-05-02 16:52 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2006-01-31 18:57:58 PST
 
Comment 1 Adele Peterson 2006-03-01 17:01:11 PST
<rdar://problem/4463541> Display correct context menus for new text fields (6988)
Comment 2 Adele Peterson 2006-03-29 17:49:44 PST
Bumping to P1 since this causes a text field regression
Comment 3 Maciej Stachowiak 2006-04-02 23:25:36 PDT
These are all text field regressions so they should all be P1.
Comment 4 Darin Adler 2006-04-21 18:35:34 PDT
Adele, I know you've been working on this. Could you add some notes about your progress so far?
Comment 5 Adele Peterson 2006-04-21 23:16:24 PDT
Right now, the context menu that comes up includes:

Search in Spotlight
Search in Google
-----------------
Look Up in Dictionary
-----------------
Copy (if there's a selection)
-----------------
Inspect Element (if the default is turned on for this)

I think we want to have a menu like this:

"spelling suggestions" (if misspelled word is selected)
--------------------
Ignore Spelling (if misspelled word is selected)
Learn Spelling (if misspelled word is selected)
-------------------
Open URL (if selection looks like URL)
-------------------
Search in Spotlight
Search in Google
----------------------
Look Up in Dictionary
----------------------
Cut (dimmed at appropriate times)
Copy (dimmed at appropriate times)
Paste (dimmed at appropriate times)
----------------------
Spelling              >
Speech               >
-----------------
Inspect Element (if the default is turned on for this)

The menu items we'd be leaving out from existing NSTextFields would be:
Make Link, Font, Writing Direction

We have a nib for an editing context menu in WebKit right now, but Safari doesn't use that context menu (I think only Mail does).  I'm not sure why we don't use that menu for contenteditable elements.  I'm not sure if we'll need to add another nib specifically for the text fields or if we can somehow use the existing nib, and the existing code for the editing menu and alter it to be used for both purposes.