Bug 6930 - % width/height on nested <svg> tags do not work
Summary: % width/height on nested <svg> tags do not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-30 00:44 PST by Eric Seidel (no email)
Modified: 2006-04-09 14:52 PDT (History)
0 users

See Also:


Attachments
Simple test case (261 bytes, image/svg+xml)
2006-01-30 00:46 PST, Eric Seidel (no email)
no flags Details
Proposed fix (3.79 KB, patch)
2006-04-09 06:33 PDT, Rob Buis
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-01-30 00:44:13 PST
% width/height on nested <svg> tags do not work

I'm not sure how visible this bug is, as I'm not sure how many svgs use nested <svg> tags.  Should be a simple fix.
Comment 1 Eric Seidel (no email) 2006-01-30 00:46:13 PST
Created attachment 6102 [details]
Simple test case
Comment 2 Rob Buis 2006-04-09 06:33:13 PDT
Created attachment 7597 [details]
Proposed fix
Comment 3 Darin Adler 2006-04-09 09:10:05 PDT
Comment on attachment 7597 [details]
Proposed fix

+        lazy_create<SVGAnimatedLength>(m_width, (SVGStyledElement *)ownerDocument()->documentElement() == this ? 0 : this, LM_WIDTH, viewport);

You should remove the typecast to (SVGStyledElement*). It's not needed.

Anyway, r=me
Comment 4 Eric Seidel (no email) 2006-04-09 12:31:39 PDT
Comment on attachment 7597 [details]
Proposed fix

beautiful test case rob!