Bug 6818 – garbage collect a bit later when destroying Frame (fixes node leak false positives)

• Status: RESOLVED
• Resolution: FIXED
• Component: Frames

[Maciej Stachowiak]

Frame clears the properties of the window object and garbage collects every time you change documents. This is good, because you don't want to leak custom properties to the next document, and because much garbage will be created when the properties are cleared.

However, it also does this on destruction. That's suboptimal, because the window object itself (and everything it keeps alive) will become collectable after the ScriptInterpreter is destroyed. So the clearing is a waste of time, and the garbage collection would be better done later.

On top of all that, this causes false positives from the NodeImpl leak counter.

[Maciej Stachowiak]

Created attachment 5969 [details]
skip the clear, GC after destroying ScriptInterpreter

[Dave Hyatt]

Comment on attachment 5969 [details]
skip the clear, GC after destroying ScriptInterpreter

r=me but run the PLT and layout tests.