WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
6809
Whole DOM tree can leak if Document is hover/active/focus node on quit
https://bugs.webkit.org/show_bug.cgi?id=6809
Summary
Whole DOM tree can leak if Document is hover/active/focus node on quit
Maciej Stachowiak
Reported
2006-01-25 17:23:34 PST
DocumentImpl keeps the hover, active and focus nodes referenced, so the whole DOM tree can leak if the document itself is hover, active or focus when leaving the page. Without this fix, the editing layout tests show 175 NodeImpl leaks with the counter enabled.
Attachments
patch to fix the leak when document is hover/active/focus node
(1.92 KB, patch)
2006-01-25 18:04 PST
,
Maciej Stachowiak
hyatt
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1
2006-01-25 18:04:12 PST
Created
attachment 5966
[details]
patch to fix the leak when document is hover/active/focus node I'm not sure if this is the best approach. Maybe it should be FrameView, not Document, that tracks these nodes.
Dave Hyatt
Comment 2
2006-01-25 18:08:35 PST
Comment on
attachment 5966
[details]
patch to fix the leak when document is hover/active/focus node r=me, although the hover/active node should never be the document.
Maciej Stachowiak
Comment 3
2006-01-25 19:04:31 PST
The hover/active node becomes the document because detaching a node makes it walk up the parent chain until it finds a node with a renderer, which the document itself still does when first detaching.
Lucas Forschler
Comment 4
2019-02-06 09:04:09 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug