Bug 6785 - Fix for possible leak of applet, object, or embed (and plugin view)
Summary: Fix for possible leak of applet, object, or embed (and plugin view)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Critical
Assignee: Tim Omernick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-25 00:49 PST by Tim Omernick
Modified: 2006-02-03 20:56 PST (History)
0 users

See Also:

Attachments
Patch (4.46 KB, patch)
2006-01-25 00:52 PST, Tim Omernick 		timo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Omernick 2006-01-25 00:49:52 PST 
An application which uses WebKit might leak plugins if it uses -[WebScriptObject setValue:forKey:] to alter an <embed> element's style.  Doing so causes HTMLObjectElementImpl to create and cache a KJS::Bindings::Instance, which it owns but never deletes.

I've got a patch which fixes the problem, and a similar problem with <object> and <applet>.
Comment 1 Tim Omernick 2006-01-25 00:52:33 PST 
Created attachment 5941 [details]
Patch
Comment 2 Tim Omernick 2006-01-25 13:55:22 PST 
Comment on attachment 5941 [details]
Patch

Dave Harrison reviewed this.
Comment 3 Darin Adler 2006-02-03 20:56:55 PST 
Tim landed this 2006-01-24.