- renamed PointerHash to PtrHash - made PtrHash the default hash function for int and pointer types that aren't further specialized - added an AtomicStringImpl class to make it easier and more typesafe to identity hash atomic strings - did appropriate consequent cleanup (very few places now need to declare a hash function)
Created attachment 5902 [details] cleanup patch
Comment on attachment 5902 [details] cleanup patch Funny, I have the same patch for htmlfactory.cpp -- I can discard that now. + AtomicString n = getAttribute(nameAttr); Why not make that const AtomicString&? Also, HTMLGenericFormElementImpl::name() can also return const AtomicString& if we have a way to get a reference to a global empty atomic string. In general it's great to have functions that return const AtomicString& when they are attributes to avoid any reference count churn. Looks good. I didn't spot any problems. r=me