Bug 6705 – use PassRefPtr in more of the basic DOM operations

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Darin Adler]

I was looking at some bug (can't remember which) and came to the conclusion that to fix it I would want to change cloneNode to return PassRefPtr as we've long planned.

When I started on that, the patch got too big, so I decided to start a bit smaller by changing the other basic DOM operations to use PassRefPtr instead of raw pointers.

[Darin Adler]

Created attachment 5824 [details]
less raw pointer, more PassRefPtr

[Anders Carlsson]

Comment on attachment 5824 [details]
less raw pointer, more PassRefPtr

Looks good, just a few stylistic comments:

* In ContainerNodeImpl::insertBefore:

-            newParent->removeChild( child, exceptioncode );
-        if (exceptioncode)
+            newParent->removeChild( child, ec );
+        if (ec)

the spacing should be fixed in the call to removeChild

ContainerNodeImpl::removeChild:

+    if (next) next->setPreviousSibling(prev);
+    if (prev) prev->setNextSibling(next);
+    if (m_firstChild == child) m_firstChild = next;
+    if (m_lastChild == child) m_lastChild = prev;

the statements should be on a separate line from the expressions, like in ContainerNodeImpl::replaceChild

* HTMLOptGroupElementImpl::insertBefore: 

the spacing in the function call declaration should be fixed

[Lucas Forschler]

Mass moving XML DOM bugs to the "DOM" Component.