Bug 6670 - split html_miscimpl.* and move html_elementimpl.*
Summary: split html_miscimpl.* and move html_elementimpl.*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-19 03:46 PST by Eric Seidel (no email)
Modified: 2006-01-20 02:22 PST (History)
0 users

See Also:

Attachments
proposed patch. (240.47 KB, patch)
2006-01-19 03:47 PST, Eric Seidel (no email) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-01-19 03:46:18 PST 
split html_miscimpl.* and move html_elementimpl.*

html_miscimpl.* becomes:
HTMLFormCollectionImpl.*
HTMLCollectionImpl.*
HTMLBaseFontElementImpl.*
HTMLNameCollectionImpl.*

html_elementimpl.* moves to HTMLElementImpl.*
Comment 1 Eric Seidel (no email) 2006-01-19 03:47:48 PST 
Created attachment 5781 [details]
proposed patch.
Comment 2 Eric Seidel (no email) 2006-01-19 03:48:43 PST 
Comment on attachment 5781 [details]
proposed patch.

I just used my split script like always... then went back through and fixe the
headers.  I also cleaned up a couple uses of namespace DOM and namespace khtml
while I was in there and removed a couple kdDebug calls.  That's it.
Comment 3 Darin Adler 2006-01-19 10:41:56 PST 
Comment on attachment 5781 [details]
proposed patch.

+template <class T> class QPtrVector;

I prefer "typename T" to "class T" in such lines and we've been using that
syntax as much as possible.

Looks great, r=me.