6637 – selecting node in Inspector after closing window crashes Safari

RESOLVED FIXED 6637

selecting node in Inspector after closing window crashes Safari

https://bugs.webkit.org/show_bug.cgi?id=6637

Summary selecting node in Inspector after closing window crashes Safari

Michael Croft

Reported 2006-01-17 19:51:20 PST

Select an element in Safari and Inspect it. Select the element in the node selection window Close Safari window. Select another element in the Web Inspector. Crash.

Attachments
patch for review (5.17 KB, patch) 2006-04-18 19:04 PDT, James G. Speth	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Croft

Comment 1 2006-01-17 19:51:36 PST

May be related to 6635

Mark Rowe (bdash)

Comment 2 2006-01-17 22:11:54 PST

Confirmed with ToT. This looks unrelated to bug 6635. Backtrace from the crash is as follows: Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_PROTECTION_FAILURE (0x0002) at 0x00000140 Thread 0 Crashed: 0 com.apple.WebCore 0x0113bc3c Frame::jScript() + 20 1 libobjc.A.dylib 0x909c01f4 objc_msgSend + 244 2 com.apple.WebCore 0x01191bf0 -[WebScriptObject(WebScriptObjectInternal) _initializeScriptDOMNodeImp] + 152 3 com.apple.JavaScriptCore 0x0014f754 -[WebScriptObject _imp] + 60 4 com.apple.JavaScriptCore 0x0014c78c KJS::Bindings::convertObjcValueToValue(KJS::ExecState*, void*, KJS::Bindings::ObjcValueType) + 516 5 com.apple.JavaScriptCore 0x0014b9f8 KJS::Bindings::ObjcInstance::invokeMethod(KJS::ExecState*, KJS::Bindings::MethodList const&, KJS::List const&) + 820 6 com.apple.JavaScriptCore 0x001482a8 KJS::RuntimeMethod::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 252 7 com.apple.JavaScriptCore 0x0012baec KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 96 8 com.apple.JavaScriptCore 0x00125a90 KJS::FunctionCallDotNode::evaluate(KJS::ExecState*) + 464 9 com.apple.JavaScriptCore 0x001236d4 KJS::VarDeclNode::evaluate(KJS::ExecState*) + 88 10 com.apple.JavaScriptCore 0x0011f8f0 KJS::VarDeclListNode::evaluate(KJS::ExecState*) + 84 11 com.apple.JavaScriptCore 0x00122684 KJS::VarStatementNode::execute(KJS::ExecState*) + 104 12 com.apple.JavaScriptCore 0x00122d5c KJS::SourceElementsNode::execute(KJS::ExecState*) + 188 13 com.apple.JavaScriptCore 0x00122604 KJS::BlockNode::execute(KJS::ExecState*) + 132 14 com.apple.JavaScriptCore 0x00111f90 KJS::DeclaredFunctionImp::execute(KJS::ExecState*) + 56 15 com.apple.JavaScriptCore 0x001121d0 KJS::FunctionImp::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 444 16 com.apple.JavaScriptCore 0x0012baec KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 96 17 com.apple.JavaScriptCore 0x00126b94 KJS::FunctionCallResolveNode::evaluate(KJS::ExecState*) + 456 18 com.apple.JavaScriptCore 0x00122474 KJS::ExprStatementNode::execute(KJS::ExecState*) + 104 19 com.apple.JavaScriptCore 0x00122d5c KJS::SourceElementsNode::execute(KJS::ExecState*) + 188 20 com.apple.JavaScriptCore 0x00122604 KJS::BlockNode::execute(KJS::ExecState*) + 132 21 com.apple.JavaScriptCore 0x001127ec KJS::GlobalFuncImp::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 652 22 com.apple.JavaScriptCore 0x0012baec KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 96 23 com.apple.JavaScriptCore 0x00126b94 KJS::FunctionCallResolveNode::evaluate(KJS::ExecState*) + 456 24 com.apple.JavaScriptCore 0x00122474 KJS::ExprStatementNode::execute(KJS::ExecState*) + 104 25 com.apple.JavaScriptCore 0x00122e04 KJS::SourceElementsNode::execute(KJS::ExecState*) + 356 26 com.apple.JavaScriptCore 0x00122604 KJS::BlockNode::execute(KJS::ExecState*) + 132 27 com.apple.JavaScriptCore 0x00111f90 KJS::DeclaredFunctionImp::execute(KJS::ExecState*) + 56 28 com.apple.JavaScriptCore 0x001121d0 KJS::FunctionImp::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 444 29 com.apple.JavaScriptCore 0x0012baec KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 96 30 com.apple.JavaScriptCore 0x00150b28 -[WebScriptObject callWebScriptMethod:withArguments:] + 376 31 com.apple.WebKit 0x00378d4c -[WebInspector(WebInspectorPrivate) _update] + 96 32 com.apple.WebKit 0x00377294 -[WebInspector setFocusedDOMNode:] + 304 33 com.apple.WebKit 0x00379864 -[WebInspector(WebInspectorPrivate) outlineViewSelectionDidChange:] + 136 34 com.apple.Foundation 0x928d4018 _nsnote_callback + 180 35 com.apple.CoreFoundation 0x907854c4 __CFXNotificationPost + 368 36 com.apple.CoreFoundation 0x9077d5a0 _CFXNotificationPostNotification + 684 37 com.apple.Foundation 0x928be420 -[NSNotificationCenter postNotificationName:object:userInfo:] + 92 38 com.apple.AppKit 0x93721518 -[NSTableView _enableSelectionPostingAndPost] + 424 39 com.apple.AppKit 0x937365f4 -[NSTableView mouseDown:] + 2768 40 com.apple.AppKit 0x937f5a30 -[NSOutlineView mouseDown:] + 680 41 com.apple.WebCore 0x01147014 MacFrame::passMouseDownEventToWidget(QWidget*) + 832 42 com.apple.WebCore 0x0114a7a0 MacFrame::khtmlMousePressEvent (WebCore::MousePressEvent*) + 144 43 com.apple.WebCore 0x01278194 ObjectContents::event(QEvent*) + 28 44 com.apple.WebCore 0x01154f64 KHTMLView::viewportMousePressEvent(QMouseEvent*) + 564 45 com.apple.WebCore 0x0114d9c0 MacFrame::mouseDown(NSEvent*) + 544 46 com.apple.WebKit 0x00340210 -[WebHTMLView mouseDown:] + 272 47 com.apple.AppKit 0x936d5eb0 -[NSWindow sendEvent:] + 4616 48 com.apple.WebKit 0x0037c8fc -[WebInspectorPanel sendEvent:] + 764 49 com.apple.AppKit 0x9367eef4 -[NSApplication sendEvent:] + 4172 50 com.apple.Safari 0x00021c64 0x1000 + 134244 51 com.apple.AppKit 0x93676330 -[NSApplication run] + 508 52 com.apple.AppKit 0x93766e68 NSApplicationMain + 452 53 com.apple.Safari 0x0005cfdc 0x1000 + 376796 54 com.apple.Safari 0x0005ce80 0x1000 + 376448

Alice Liu

Comment 3 2006-01-26 18:26:56 PST

<rdar://problem/4417355>

Darin Adler

Comment 4 2006-02-19 12:59:06 PST

I tried, and could not reproduce this problem today.

Michael Croft

Comment 5 2006-02-19 20:23:29 PST

(In reply to comment #4) > I tried, and could not reproduce this problem today. > Still happening for me with current TOT. Date/Time: 2006-02-19 23:18:27.652 -0500 OS Version: 10.4.5 (Build 8H14) Report Version: 4 Command: Safari Path: /Applications/Safari.app/Contents/MacOS/Safari Parent: bash [277] Version: 2.0.3 (417.8) Build Version: 1 Project Name: WebBrowser Source Version: 4170800 PID: 4265 Thread: 0 Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_PROTECTION_FAILURE (0x0002) at 0x00000044 Thread 0 Crashed: 0 com.apple.WebCore 0x0199139c WebCore::Frame::jScript() + 28 (Frame.cpp:375) 1 com.apple.WebCore 0x01a0cbe4 -[WebScriptObject(WebScriptObjectInternal) _initializeScriptDOMNodeImp] + 148 (DOMInternal.mm:183) 2 com.apple.JavaScriptCore 0x01068c54 -[WebScriptObject _imp] + 68 (WebScriptObject.mm:96) 3 com.apple.JavaScriptCore 0x01065314 KJS::Bindings::convertObjcValueToValue(KJS::ExecState*, void*, KJS::Bindings::ObjcValueType) + 500 (objc_utility.mm:238) 4 com.apple.JavaScriptCore 0x01064348 KJS::Bindings::ObjcInstance::invokeMethod(KJS::ExecState*, KJS::Bindings::MethodList const&, KJS::List const&) + 1000 (objc_instance.mm:230) 5 com.apple.JavaScriptCore 0x0105f9e4 KJS::RuntimeMethod::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 276 (runtime_method.cpp:93) 6 com.apple.JavaScriptCore 0x0103bc24 KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 100 (object.cpp:99) 7 com.apple.JavaScriptCore 0x0102d7bc KJS::FunctionCallDotNode::evaluate(KJS::ExecState*) + 524 (nodes.cpp:695) 8 com.apple.JavaScriptCore 0x0102b6d8 KJS::VarDeclNode::evaluate(KJS::ExecState*) + 88 (nodes.cpp:1523) 9 com.apple.JavaScriptCore 0x0102b61c KJS::VarDeclListNode::evaluate(KJS::ExecState*) + 76 (nodes.cpp:1570) 10 com.apple.JavaScriptCore 0x01031ef8 KJS::VarStatementNode::execute(KJS::ExecState*) + 104 (nodes.cpp:1594) 11 com.apple.JavaScriptCore 0x0103545c KJS::SourceElementsNode::execute(KJS::ExecState*) + 252 (nodes.cpp:2390) 12 com.apple.JavaScriptCore 0x01032098 KJS::BlockNode::execute(KJS::ExecState*) + 152 (nodes.cpp:1627) 13 com.apple.JavaScriptCore 0x0101a0f8 KJS::DeclaredFunctionImp::execute(KJS::ExecState*) + 56 (completion.h:53) 14 com.apple.JavaScriptCore 0x01019a10 KJS::FunctionImp::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 464 (interpreter.h:470) 15 com.apple.JavaScriptCore 0x0103bc24 KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 100 (object.cpp:99) 16 com.apple.JavaScriptCore 0x0102df5c KJS::FunctionCallResolveNode::evaluate(KJS::ExecState*) + 524 (nodes.cpp:602) 17 com.apple.JavaScriptCore 0x01032168 KJS::ExprStatementNode::execute(KJS::ExecState*) + 104 (nodes.cpp:1651) 18 com.apple.JavaScriptCore 0x0103545c KJS::SourceElementsNode::execute(KJS::ExecState*) + 252 (nodes.cpp:2390) 19 com.apple.JavaScriptCore 0x01032098 KJS::BlockNode::execute(KJS::ExecState*) + 152 (nodes.cpp:1627) 20 com.apple.JavaScriptCore 0x01018b7c KJS::GlobalFuncImp::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 748 (interpreter.h:470) 21 com.apple.JavaScriptCore 0x0103bc24 KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 100 (object.cpp:99) 22 com.apple.JavaScriptCore 0x0102df5c KJS::FunctionCallResolveNode::evaluate(KJS::ExecState*) + 524 (nodes.cpp:602) 23 com.apple.JavaScriptCore 0x01032168 KJS::ExprStatementNode::execute(KJS::ExecState*) + 104 (nodes.cpp:1651) 24 com.apple.JavaScriptCore 0x01035548 KJS::SourceElementsNode::execute(KJS::ExecState*) + 488 (completion.h:53) 25 com.apple.JavaScriptCore 0x01032098 KJS::BlockNode::execute(KJS::ExecState*) + 152 (nodes.cpp:1627) 26 com.apple.JavaScriptCore 0x0101a0f8 KJS::DeclaredFunctionImp::execute(KJS::ExecState*) + 56 (completion.h:53) 27 com.apple.JavaScriptCore 0x01019a10 KJS::FunctionImp::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 464 (interpreter.h:470) 28 com.apple.JavaScriptCore 0x0103bc24 KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 100 (object.cpp:99) 29 com.apple.JavaScriptCore 0x0106a570 -[WebScriptObject callWebScriptMethod:withArguments:] + 448 (WebScriptObject.mm:210) 30 com.apple.WebKit 0x00383104 -[WebInspector(WebInspectorPrivate) _update] + 100 (WebInspector.m:644) 31 com.apple.WebKit 0x00381414 -[WebInspector setFocusedDOMNode:] + 324 (WebInspector.m:226) 32 com.apple.WebKit 0x00383d38 -[WebInspector(WebInspectorPrivate) outlineViewSelectionDidChange:] + 136 (WebInspector.m:917) 33 com.apple.Foundation 0x928e6cf8 _nsnote_callback + 180 34 com.apple.CoreFoundation 0x907844c4 __CFXNotificationPost + 368 35 com.apple.CoreFoundation 0x9077c5a0 _CFXNotificationPostNotification + 684 36 com.apple.Foundation 0x928d1100 -[NSNotificationCenter postNotificationName:object:userInfo:] + 92 37 com.apple.AppKit 0x93734518 -[NSTableView _enableSelectionPostingAndPost] + 424 38 com.apple.AppKit 0x937495f4 -[NSTableView mouseDown:] + 2768 39 com.apple.AppKit 0x93808a30 -[NSOutlineView mouseDown:] + 680 40 com.apple.WebCore 0x019a07f8 WebCore::MacFrame::passMouseDownEventToWidget(WebCore::Widget*) + 888 (MacFrame.mm:1542) 41 com.apple.WebCore 0x019a6870 WebCore::MacFrame::khtmlMousePressEvent(WebCore::MousePressEvent*) + 240 (MacFrame.mm:1466) 42 com.apple.WebCore 0x019b6614 WebCore::FrameView::viewportMousePressEvent(QMouseEvent*) + 452 (RefPtr.h:50) 43 com.apple.WebCore 0x019aeccc WebCore::MacFrame::mouseDown(NSEvent*) + 620 (MacFrame.mm:2041) 44 com.apple.WebKit 0x00344600 -[WebHTMLView mouseDown:] + 272 (WebHTMLView.m:2636) 45 com.apple.AppKit 0x936e8eb0 -[NSWindow sendEvent:] + 4616 46 com.apple.WebKit 0x00386c48 -[WebInspectorPanel sendEvent:] + 808 (WebInspectorPanel.m:154) 47 com.apple.AppKit 0x93691ef4 -[NSApplication sendEvent:] + 4172 48 com.apple.Safari 0x00021c64 0x1000 + 134244 49 com.apple.AppKit 0x93689330 -[NSApplication run] + 508 50 com.apple.AppKit 0x93779e68 NSApplicationMain + 452 51 com.apple.Safari 0x0005cfdc 0x1000 + 376796 52 com.apple.Safari 0x0005ce80 0x1000 + 376448 Thread 1: 0 libSystem.B.dylib 0x9000b1e8 mach_msg_trap + 8 1 libSystem.B.dylib 0x9000b13c mach_msg + 60 2 com.apple.CoreFoundation 0x9075d114 __CFRunLoopRun + 832 3 com.apple.CoreFoundation 0x9075ca18 CFRunLoopRunSpecific + 268 4 com.apple.Foundation 0x928f6384 -[NSRunLoop runMode:beforeDate:] + 172 5 com.apple.Foundation 0x928f62bc -[NSRunLoop run] + 76 6 com.apple.WebKit 0x0036ca74 +[WebFileDatabase _syncLoop:] + 180 (WebFileDatabase.m:291) 7 com.apple.Foundation 0x928e73b4 forkThreadForFunction + 108 8 libSystem.B.dylib 0x9002b1e0 _pthread_body + 96 Thread 2: 0 libSystem.B.dylib 0x9000b1e8 mach_msg_trap + 8 1 libSystem.B.dylib 0x9000b13c mach_msg + 60 2 com.apple.CoreFoundation 0x9075d114 __CFRunLoopRun + 832 3 com.apple.CoreFoundation 0x9075ca18 CFRunLoopRunSpecific + 268 4 com.apple.Foundation 0x9290e8bc +[NSURLConnection(NSURLConnectionInternal) _resourceLoadLoop:] + 264 5 com.apple.Foundation 0x928e73b4 forkThreadForFunction + 108 6 libSystem.B.dylib 0x9002b1e0 _pthread_body + 96 Thread 3: 0 libSystem.B.dylib 0x9000b1e8 mach_msg_trap + 8 1 libSystem.B.dylib 0x9000b13c mach_msg + 60 2 com.apple.CoreFoundation 0x9075d114 __CFRunLoopRun + 832 3 com.apple.CoreFoundation 0x9075ca18 CFRunLoopRunSpecific + 268 4 com.apple.Foundation 0x9290f9fc +[NSURLCache _diskCacheSyncLoop:] + 152 5 com.apple.Foundation 0x928e73b4 forkThreadForFunction + 108 6 libSystem.B.dylib 0x9002b1e0 _pthread_body + 96 Thread 4: 0 libSystem.B.dylib 0x9001f1ec select + 12 1 com.apple.CoreFoundation 0x9076f9a8 __CFSocketManager + 472 2 libSystem.B.dylib 0x9002b1e0 _pthread_body + 96 Thread 5: 0 libSystem.B.dylib 0x9002b888 semaphore_wait_signal_trap + 8 1 libSystem.B.dylib 0x9002fffc pthread_cond_wait + 488 2 com.apple.Foundation 0x928ee520 -[NSConditionLock lockWhenCondition:] + 68 3 com.apple.Syndication 0x99f3850c -[AsyncDB _run:] + 192 4 com.apple.Foundation 0x928e73b4 forkThreadForFunction + 108 5 libSystem.B.dylib 0x9002b1e0 _pthread_body + 96 Thread 0 crashed with PPC Thread State 64: srr0: 0x000000000199139c srr1: 0x100000000200f030 vrsave: 0x0000000000000000 cr: 0x24022202 xer: 0x0000000000000000 lr: 0x0000000001a0cbe4 ctr: 0x00000000019e7df0 r0: 0x0000000001a0cbe4 r1: 0x00000000bfffbe30 r2: 0x0000000000000000 r3: 0x0000000000000000 r4: 0x00000000909ec0a0 r5: 0x0000000001bf779c r6: 0x0000000000000001 r7: 0x0000000000000001 r8: 0x000000004000758b r9: 0x00000000010be1cc r10: 0x0000000000000041 r11: 0x000000000000007c r12: 0x00000000019e7df0 r13: 0x00000000a36b7ca8 r14: 0x0000000000000100 r15: 0x0000000000000000 r16: 0x00000000a36b7ca8 r17: 0x0000000000000000 r18: 0x0000000022e883a0 r19: 0x00000000220cb060 r20: 0x00000000bfffd32c r21: 0x0000000000685d10 r22: 0x0000000000000001 r23: 0x000000000109800c r24: 0x00000000248f4670 r25: 0x00000000010c5130 r26: 0x00000000010c5130 r27: 0x00000000bfffcb64 r28: 0x0000000000000000 r29: 0x00000000006ad580 r30: 0x0000000023345220 r31: 0x0000000001a0cb50

James G. Speth

Comment 6 2006-04-18 19:04:35 PDT

Created attachment 7813 [details] patch for review when the window it was inspecting is closed, the inspector goes into its no-selection state. choosing to inspect another element activates it again.

Timothy Hatcher

Comment 7 2006-04-19 12:00:47 PDT

Comment on attachment 7813 [details] patch for review Looks good, tested and works great. r=me One style note for the future. + } + else This should be: + } else I will fix this when I land. Please attach a ChangeLog so I can land this.

Timothy Hatcher

Comment 8 2006-04-19 18:40:56 PDT

Landed in r13976.

David Kilzer (:ddkilzer)

Comment 9 2006-06-11 04:57:40 PDT

*** Bug 6922 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P1

Severity Critical

Classification Unclassified

Version 420+

Hardware Mac

OS OS X 10.4

Product WebKit

Component Web Inspector (Deprecated)

Assignee

Nobody

Reported

2006-01-17 19:51 PST

Modified

2006-06-11 04:57 PDT History

CC List

2 users Show

URL

Keywords InRadar

Duplicates (1)

6922 View as bug list

Depends on

Blocks