Bug 6633 - WebKit-no-SVG should be removed, replaced by using #if SVG_SUPPORT only
Summary: WebKit-no-SVG should be removed, replaced by using #if SVG_SUPPORT only
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-17 18:39 PST by Eric Seidel (no email)
Modified: 2006-01-22 06:07 PST (History)
0 users

See Also:

Attachments
script to fix headers (560 bytes, text/x-perl-script)
2006-01-22 05:25 PST, Eric Seidel (no email) 		no flags Details
script to fix source files (564 bytes, text/x-perl-script)
2006-01-22 05:25 PST, Eric Seidel (no email) 		no flags Details
resulting patch (347.07 KB, patch)
2006-01-22 05:29 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
patch fixing a couple compile errors for SVG_SUPPORT (348.46 KB, patch)
2006-01-22 05:55 PST, Eric Seidel (no email) 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-01-17 18:39:23 PST 
WebKit-no-SVG should be removed, replaced by using #if SVG_SUPPORT only

All of the .cpp files in ksvg2 and kcanvas will need to be wrapped in #if SVG_SUPPORT.

This will have to be placed after #include config.h so that config.h can control whether SVG_SUPPORT is 
used.

We might need to wrapp the .h files as well, I'm not sure.
Comment 1 Eric Seidel (no email) 2006-01-22 05:25:20 PST 
Created attachment 5837 [details]
script to fix headers
Comment 2 Eric Seidel (no email) 2006-01-22 05:25:41 PST 
Created attachment 5838 [details]
script to fix source files
Comment 3 Eric Seidel (no email) 2006-01-22 05:29:00 PST 
Created attachment 5839 [details]
resulting patch

This patch removes the WebCore-no-svg target, and wraps all SVG specific files in #if SVG_SUPPORT, usign the attached scripts.
Comment 4 Eric Seidel (no email) 2006-01-22 05:55:42 PST 
Created attachment 5840 [details]
patch fixing a couple compile errors for SVG_SUPPORT
Comment 5 Anders Carlsson 2006-01-22 06:04:15 PST 
Comment on attachment 5840 [details]
patch fixing a couple compile errors for SVG_SUPPORT

r=me