Bug 6632 – REGRESSION: Selection includes spaces that it shouldn't

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Justin Garcia]

Do a Find for "SVG".  Use Command-G to find it again.
Shrink the window, so that the occurrence of 'SVG' that was found is at the beginning of the line.
The selection will now contain the space before the beginning of the line.  Trying to reselect 'SVG' won't fix 
the problem.  It is impossible to select just 'SVG'.

[Justin Garcia]

See:

<rdar://problem/4407845> REGRESSION (TOT): blank space before found text selected at http://
www.schepers.cc/comiclinks.html

[Justin Garcia]

Created attachment 5749 [details]
reduction

[Justin Garcia]

Created attachment 5751 [details]
patch

What do you give to the function that already has everything?

p.downstream() and p.upstream() shouldn't return positions that aren't visually
equivalent.  By "visually equivalent" I mean two positions where
VisiblePosition(a) == VisiblePosition(b).

Also includes a change to VisiblePosition::previous that wasn't really
necessary for the fix:
When moving backward through the DOM using Position::previous, don't return the
first candidate found, because it may be visually equivalent to the original
(and we don't want VisiblePosition::previous returning something visually
equivalent).  
I think that the code assumed that the leftmost candidate was always chosen as
the canonical position in VisiblePosition::init (in which case the first
candidate found when moving backward would always be visually distinct from the
original).  The leftmost candidate is usually chosen, but not always.  In fact,
see <http://bugzilla.opendarwin.org/show_bug.cgi?id=6476>.

[Darin Adler]

Comment on attachment 5751 [details]
patch

r=me