Bug 6561 - run-javascriptcore-tests doesn't work
Summary: run-javascriptcore-tests doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-15 06:14 PST by Alexey Proskuryakov
Modified: 2006-01-15 06:37 PST (History)
1 user (show)

See Also:


Attachments
Change exactly as Alexey describes. (616 bytes, patch)
2006-01-15 06:30 PST, Mark Rowe (bdash)
mrowe: review-
Details | Formatted Diff | Diff
proposed fix (1.51 KB, patch)
2006-01-15 06:30 PST, Alexey Proskuryakov
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2006-01-15 06:14:26 PST
$ run-javascriptcore-tests 
Invalid version number at Getopt/Mixed.pm line 52.
BEGIN failed--compilation aborted at Getopt/Mixed.pm line 55.
Compilation failed in require at jsDriver.pl line 40.
BEGIN failed--compilation aborted at jsDriver.pl line 40.

In Mixed.pm:
    # Convert RCS revision number (must be main branch) to d.ddd format:
    ' $Revision: 7020 $ ' =~ / (\d+)\.(\d{1,3}) /
        or die "Invalid version number";

The correct revision number to have here is 1.8 (CVS WebKit used to have 1.1, which was wrong).

This has apparently happened with svn migration; not sure about what steps to fix would be right 
(might require some svn magic).
Comment 1 Mark Rowe (bdash) 2006-01-15 06:30:20 PST
Created attachment 5695 [details]
Change exactly as Alexey describes.

No SVN magic is needed.  The file in question has already had keyword expansion
disabled.
Comment 2 Alexey Proskuryakov 2006-01-15 06:30:48 PST
Created attachment 5696 [details]
proposed fix

Ok, Mark (bdash) says there's no longer any magic in this file, and the
revision can be simply replaced with a correct value :)
Comment 3 Anders Carlsson 2006-01-15 06:33:36 PST
Comment on attachment 5696 [details]
proposed fix

Why should the revision number be 1.8?

r=me
Comment 4 Alexey Proskuryakov 2006-01-15 06:37:49 PST
1.008 is the version of WebKit's copy, see <http://search.cpan.org/src/CJM/Getopt-Mixed-1.008/lib/
Getopt/Mixed.pm>.