Bug 65596 - [EFL] Implement dummy IconDatabaseClientEfl
Summary: [EFL] Implement dummy IconDatabaseClientEfl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-03 00:21 PDT by Jaehun Lim
Modified: 2011-08-24 02:49 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (5.14 KB, patch)
2011-08-03 00:24 PDT, Jaehun Lim 		no flags Details | Formatted Diff | Diff
Proposed patch (5.13 KB, patch)
2011-08-03 15:24 PDT, Jaehun Lim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaehun Lim 2011-08-03 00:21:26 PDT 
Adds two files, IconDatabaseClientEfl.h | .cpp to implement IconDatabaseClient for EFL port.
Comment 1 Jaehun Lim 2011-08-03 00:24:45 PDT 
Created attachment 102746 [details]
Proposed patch
Comment 2 Leandro Pereira 2011-08-03 08:21:08 PDT 
Comment on attachment 102746 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102746&action=review

LGTM, just a minor nit.

> Source/WebKit/efl/WebCoreSupport/IconDatabaseClientEfl.cpp:39
> +void IconDatabaseClientEfl::didImportIconURLForPageURL(const String& url)

Unused parameters shouldn't have their names declared.
Comment 3 Jaehun Lim 2011-08-03 15:24:26 PDT 
Created attachment 102838 [details]
Proposed patch

Thanks for your comments. I uploaded a new patch.
Comment 4 Gyuyoung Kim 2011-08-08 17:34:12 PDT 
LGTM.
Comment 5 Gyuyoung Kim 2011-08-23 20:53:35 PDT 
Kent, could you please review this patch as well ?
Comment 6 WebKit Review Bot 2011-08-24 02:49:01 PDT 
Comment on attachment 102838 [details]
Proposed patch

Clearing flags on attachment: 102838

Committed r93697: <http://trac.webkit.org/changeset/93697>
Comment 7 WebKit Review Bot 2011-08-24 02:49:06 PDT 
All reviewed patches have been landed.  Closing bug.