Bug 6528 - remove all use of QDict from WebCore
Summary: remove all use of QDict from WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-13 22:57 PST by Darin Adler
Modified: 2006-01-15 13:33 PST (History)
1 user (show)

See Also:

Attachments
remove QDict, use HashMap and HashSet instead (107.93 KB, patch)
2006-01-13 22:58 PST, Darin Adler 		hyatt: review+
Details | Formatted Diff | Diff
follow-on to fix regression in layout test (26.95 KB, patch)
2006-01-15 13:21 PST, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2006-01-13 22:57:49 PST 
We want to get rid of QDict.
Comment 1 Darin Adler 2006-01-13 22:58:34 PST 
Created attachment 5657 [details]
remove QDict, use HashMap and HashSet instead
Comment 2 Dave Hyatt 2006-01-14 01:28:17 PST 
There's tons of whitespace changes that are irrelevant to the patch.  Did you mean to include these (is this 
just because you de-tabified the files when you touched them)?
Comment 3 Dave Hyatt 2006-01-14 01:29:25 PST 
Comment on attachment 5657 [details]
remove QDict, use HashMap and HashSet instead

r=me, may be worth running performance tests just to verify everything is ok
with all the hash tables performance-wise.

Whitespace/tab changes are fine too.
Comment 4 Darin Adler 2006-01-14 10:01:05 PST 
Right, Dave, the whitespace changes are because I de-tab-ified files as I touched them.

I guess I will have to run the performance tests.
Comment 5 Anders Carlsson 2006-01-15 03:44:03 PST 
Maybe a CountedHashSet could be used for the m_idCount table instead?
Comment 6 Darin Adler 2006-01-15 06:51:16 PST 
Good idea. I used HashCountedSet for m_idCount.

I also did performance tests, and it's working well.
Comment 7 Darin Adler 2006-01-15 13:21:12 PST 
Created attachment 5700 [details]
follow-on to fix regression in layout test
Comment 8 Anders Carlsson 2006-01-15 13:33:20 PST 
Comment on attachment 5700 [details]
follow-on to fix regression in layout test

r=me