Bug 6487 – "Make Text Bigger/Smaller" affects SVGs when it probably shouldn't

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: SVG

[Eric Seidel (no email)]

"Make Text Bigger/Smaller" affects SVGs when it probably shouldn't

I know that FireFox also has this "problem".  I'm not sure what the right solution here is.  Should we zoom 
the whole SVG?  Should we disable text zoom, or should we leave it as is?

[John Sullivan]

We decided to make these menu items be equivalents for zoom in/out in PDF, though the concepts are of 
course not exactly the same. Doing the same thing for SVG seems sensible.

[Rob Buis]

Created attachment 14559 [details]
First attempt

How this option now works is not intuitive IMHO, either the whole svg should zoom in/out or this setting should be ignored, but just zooming svg text only clearly is wrong. This patch turns this behaviour off, thus no SVG text is affected by zoomFactor. Note that I think the patch still allows html text in foreignObject to zoom.
Note that this setting feels similar to zooming and panning, I made a patch for that and will attach it to another bug report soon (will make a reference here). These subjects could be dependent.
Cheers,

Rob.

[Dave Hyatt]

We have a CSS property that can turn off text zoom.  We use it in Safari RSS.  It's called -webkit-text-size-adjust.  Not sure if it would be helpful for you or not, but it is there and usable.

[Rob Buis]

Created attachment 14561 [details]
Better approach

I think Dave's approach is better as it doesnt require extra #if ENABLE(SVG).
Cheers,

Rob.

[Dave Hyatt]

Did you attach the wrong patch here?

[Rob Buis]

Created attachment 14562 [details]
Now with the right patch...

Doh!
Cheers,

Rob.

[Dave Hyatt]

Comment on attachment 14562 [details]
Now with the right patch...

r=me

[Rob Buis]

Landed in r21482.

[Andreas Kling]

I'm removing -webkit-text-size-adjust in bug 56543, and this patch to svg.css is effectively reverted. However, I don't see any difference in SVG text behavior (with text-only zoom) before/after, so I'm not sure it was even needed anymore.

@Rob, do we need to do anything with this?

[Rob Buis]

Hi Andreas,

(In reply to comment #9)
> I'm removing -webkit-text-size-adjust in bug 56543, and this patch to svg.css is effectively reverted. However, I don't see any difference in SVG text behavior (with text-only zoom) before/after, so I'm not sure it was even needed anymore.
> 
> @Rob, do we need to do anything with this?

If the behavior is the same after your patch, I am fine with the "revert". I guess a lot changed since 2007 :)

[Darin Adler]

Comment on attachment 14562 [details]
Now with the right patch...

Clearing the review flag so this does not show up as a “patch reviewed but not landed” any more.

[Ahmad Saleem]

Comment 08 mention that this landed in 2007 and then got reverted in 2013 as per Comment 09 and the behavior was pre and post revert was same, do we need to track this anymore? Thanks!

[Ahmad Saleem]

*** This bug has been marked as a duplicate of bug 59435 ***