Bug 6461 - html_formimpl.* should be split into multiple files (one per class)
Summary: html_formimpl.* should be split into multiple files (one per class)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-10 00:52 PST by Eric Seidel (no email)
Modified: 2006-01-13 00:16 PST (History)
0 users

See Also:

Attachments
patch (1 of 3) splitting html_formimpl.* into multiple classes. (618.91 KB, patch)
2006-01-10 00:57 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
patch (2 of 3) splitting html_formimpl.* into multiple classes. (374.78 KB, patch)
2006-01-10 00:58 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
patch (3 of 3) splitting html_formimpl.* into multiple classes. (906.27 KB, patch)
2006-01-10 01:00 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
split_class.pl script I used (4.10 KB, text/x-perl-script)
2006-01-10 01:01 PST, Eric Seidel (no email) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-01-10 00:52:53 PST 
html_formimpl.* should be split into multiple files (one per class)

the attached patch does just that.  I used a slightly better version of my split_class.pl script to start with, 
then mostly more manual removal.  The changes are simple, but large.  I'll happilly go over them all with 
someone over IRC.
Comment 1 Eric Seidel (no email) 2006-01-10 00:57:33 PST 
Created attachment 5588 [details]
patch (1 of 3) splitting html_formimpl.* into multiple classes.
Comment 2 Eric Seidel (no email) 2006-01-10 00:58:49 PST 
Created attachment 5591 [details]
patch (2 of 3) splitting html_formimpl.* into multiple classes.
Comment 3 Eric Seidel (no email) 2006-01-10 01:00:09 PST 
Created attachment 5593 [details]
patch (3 of 3) splitting html_formimpl.* into multiple classes.
Comment 4 Eric Seidel (no email) 2006-01-10 01:01:10 PST 
Created attachment 5594 [details]
split_class.pl script I used
Comment 5 mitz 2006-01-10 14:38:05 PST 
html_formimpl.* are still in the tree and Frame.cpp still includes html_formimpl.h
Comment 6 mitz 2006-01-13 00:16:09 PST 
(In reply to comment #5)
> html_formimpl.* are still in the tree and Frame.cpp still includes html_formimpl.h 

mjs fixed this in revision 12047.