RESOLVED FIXED 6461
html_formimpl.* should be split into multiple files (one per class) 
https://bugs.webkit.org/show_bug.cgi?id=6461
Summary html_formimpl.* should be split into multiple files (one per class)
Eric Seidel (no email)
Reported 2006-01-10 00:52:53 PST
html_formimpl.* should be split into multiple files (one per class) the attached patch does just that. I used a slightly better version of my split_class.pl script to start with, then mostly more manual removal. The changes are simple, but large. I'll happilly go over them all with someone over IRC.
Attachments
patch (1 of 3) splitting html_formimpl.* into multiple classes. (618.91 KB, patch)
2006-01-10 00:57 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
patch (2 of 3) splitting html_formimpl.* into multiple classes. (374.78 KB, patch)
2006-01-10 00:58 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
patch (3 of 3) splitting html_formimpl.* into multiple classes. (906.27 KB, patch)
2006-01-10 01:00 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
split_class.pl script I used (4.10 KB, text/x-perl-script)
2006-01-10 01:01 PST, Eric Seidel (no email) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2006-01-10 00:57:33 PST
Created attachment 5588 [details] patch (1 of 3) splitting html_formimpl.* into multiple classes.
Eric Seidel (no email)
Comment 2 2006-01-10 00:58:49 PST
Created attachment 5591 [details] patch (2 of 3) splitting html_formimpl.* into multiple classes.
Eric Seidel (no email)
Comment 3 2006-01-10 01:00:09 PST
Created attachment 5593 [details] patch (3 of 3) splitting html_formimpl.* into multiple classes.
Eric Seidel (no email)
Comment 4 2006-01-10 01:01:10 PST
Created attachment 5594 [details] split_class.pl script I used
mitz
Comment 5 2006-01-10 14:38:05 PST
html_formimpl.* are still in the tree and Frame.cpp still includes html_formimpl.h
mitz
Comment 6 2006-01-13 00:16:09 PST
(In reply to comment #5) > html_formimpl.* are still in the tree and Frame.cpp still includes html_formimpl.h mjs fixed this in revision 12047.
Note You need to log in before you can comment on or make changes to this bug.