Bug 6459 - build-webkit should exit with non-zero status when build fails
Summary: build-webkit should exit with non-zero status when build fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-09 23:31 PST by Mark Rowe (bdash)
Modified: 2006-01-10 14:16 PST (History)
0 users

See Also:

Attachments
Use correct bits of subprocess exit code when passing back through as build-webkit's exit code (1.54 KB, patch)
2006-01-09 23:36 PST, Mark Rowe (bdash) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2006-01-09 23:31:51 PST 
When xcodebuild fails, it prints '** BUILD FAILED **' but build-webkit exits with a zero exit code.  This 
makes scripting build-webkit trickier than necessary.
Comment 1 Mark Rowe (bdash) 2006-01-09 23:36:38 PST 
Created attachment 5587 [details]
Use correct bits of subprocess exit code when passing back through as build-webkit's exit code
Comment 2 Eric Seidel (no email) 2006-01-09 23:40:35 PST 
Comment on attachment 5587 [details]
Use correct bits of subprocess exit code when passing back through as build-webkit's exit code

Finally! r=me.