WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
6444
loader.* should be split into one file per class
https://bugs.webkit.org/show_bug.cgi?id=6444
Summary
loader.* should be split into one file per class
Eric Seidel (no email)
Reported
2006-01-09 00:01:55 PST
loader.* should be split into one file per class The attached patch does just that. I used the attached script on "loader.h" to svn copy loader.* to a new file for each of the contained classes. Then I went through and manually cleaned up the headers a bit, and stripped down the .cpp files. Finally I got the rest of WebCore back compiling by going through all the other .cpp files and fixing up the necessary includes. This patch not only makes the code *much* easier to read, but also substantially reduces header dependencies between files.
Attachments
my split_header script
(2.00 KB, text/x-perl-script)
2006-01-09 00:04 PST
,
Eric Seidel (no email)
no flags
Details
Splits loader.* into separate class files
(811.72 KB, patch)
2006-01-09 00:08 PST
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2006-01-09 00:04:12 PST
Created
attachment 5563
[details]
my split_header script Usage: ./split_class.pl mybigfile.h
Eric Seidel (no email)
Comment 2
2006-01-09 00:08:52 PST
Created
attachment 5564
[details]
Splits loader.* into separate class files
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug