Bug 6424 – <text>, <tspan> dominant-baseline attribute is not respected

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Eric Seidel (no email)]

<text>, <tspan> dominant-baseline attribute is not respected
http://www.w3.org/TR/SVG/text.html#DominantBaselineProperty

[Eric Seidel (no email)]

*** Bug 6873 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

See http://bugzilla.opendarwin.org/show_bug.cgi?id=6873 for a nice test case.

[Eric Seidel (no email)]

I'm almost surprised WildFox hasn't fixed this one yet in all the rest of his Text work.

[Nikolas Zimmermann]

*** Bug 14005 has been marked as a duplicate of this bug. ***

[Nikolas Zimmermann]

I postponed the baseline stuff, until the engine handles all kind of per-chunk/per-char transformations well. The last things missing before I'll start with this is:

a) textLength/lengthAdjust support for textPath
b) proper incorporation of letter/word spacing in our "buildLayoutInformation" code
     (to be able to support spacing for textPath, which is all drawn seperated..)

That's it - from the top of my head.

Greetings,
Niko

[Nikolas Zimmermann]

Created attachment 17182 [details]
Layout test results

[Nikolas Zimmermann]

Created attachment 17183 [details]
Initial patch

This does not fix Hixies glyphment align bug - gonna reopen it - it has a different origin.

[Eric Seidel (no email)]

Comment on attachment 17183 [details]
Initial patch

Hum.  We should chat about this over IRC.  This seems like it could add a lot of recursive tree walks in these (rare) cases that dominant baseline (like "nochange") is used.

[Eric Seidel (no email)]

Comment on attachment 17183 [details]
Initial patch

This is fine.  As we discussed it could be done as part of RenderStyle instead, and just cached there.  I don't expect this will ever become a perf issue however.

[Eric Seidel (no email)]

Comment on attachment 17182 [details]
Layout test results

fine.

[Nikolas Zimmermann]

Landed in r27692.