WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
6341
Move frame traversal logic from WebFrame to WebBridge
https://bugs.webkit.org/show_bug.cgi?id=6341
Summary
Move frame traversal logic from WebFrame to WebBridge
Maciej Stachowiak
Reported
2006-01-02 20:18:34 PST
Now that frame traversal is cleanly factored out, it should be moved over to WebBridge. This lays the groundwork to start moving code en masse over the bridge into WebCore.
Attachments
the patch
(19.87 KB, patch)
2006-01-02 20:21 PST
,
Maciej Stachowiak
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1
2006-01-02 20:21:07 PST
Created
attachment 5434
[details]
the patch
Eric Seidel (no email)
Comment 2
2006-01-02 20:55:26 PST
Comment on
attachment 5434
[details]
the patch Looks sane to me. I saw one tab in: +- (WebBridge *)traverseNextFrameStayWithin:(WebBridge *)stayWithin Also, incidentally, I hate variable names like "fv" if you share my hatred you could consider making those more legible as you update/move that code. Finally I asked you over IRC if there were any leaks... which it seems there were not. r=me.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug