WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
6289
REGRESSION: firstCharacterForRange(0, 0) returns a 0x0 rect
https://bugs.webkit.org/show_bug.cgi?id=6289
Summary
REGRESSION: firstCharacterForRange(0, 0) returns a 0x0 rect
mitz
Reported
2005-12-29 16:56:23 PST
The following layout tests are failing in TOT due to firstCharacterForRange(0, 0) returning a 0x0 rect: editing/input/firstrectforcharacterrange-plain editing/input/firstrectforcharacterrange-styled fast/text/attributed-substring-from-range It looks like a regression from fixing
bug 6246
.
Attachments
band-aid fix
(1.48 KB, patch)
2005-12-29 22:42 PST
,
Alexey Proskuryakov
mjs
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2005-12-29 22:42:51 PST
Created
attachment 5369
[details]
band-aid fix Looks like an indirect result of issues described in
bug 5610
: the range returned for (0, 0) in these tests is (#text, 1)-(#text,1) rather than (#text, 0)-(#text,0) - and the latter or equivalent don't give correct results in firstRectForDOMRange (which may be a separate issue). Going to cleanup this further as part of the investigation on 5610...
Maciej Stachowiak
Comment 2
2005-12-30 02:09:56 PST
r=me, looks like an ok fix for now if it gets the tests passing and doesn't break anything.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug