Bug 6261 – Misc. array object fixes from KJS

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Maks Orlovich]

Fixes:  
1. Make sure that accesses to arrays with index 2^32-1 via the int path does  
not screw things up. 2^32-1 is never a real array index property. (Kind of 
icky, I agree) 
2. Throw exception on trying to set invalid array length  
(As per 15.4.5.1, steps 12 and 13)  
3. Do not use a separator argument when doing toString/toLocalString  
  
  
Mostly merging work by Peter Kelly  
#1 and #2 are covered by KJS testcases.  
For #3:  
  
var a = new Array;  
a[0] = 5;  
a[1] = 3;  
//Shouldn't use argument for toString  
shouldBe("a.toString('!')", "'5,3'");

[Maks Orlovich]

Created attachment 5311 [details]
patch

[Maciej Stachowiak]

Comment on attachment 5311 [details]
patch

r=me, the ad-hoc test for toString needs to be converted to a proper layout
test.

[Maciej Stachowiak]

Comment on attachment 5311 [details]
patch

r=me