Bug 6249 - REGRESSION: ~2% remaining from getter/setter change
Summary: REGRESSION: ~2% remaining from getter/setter change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Critical
Assignee: Maciej Stachowiak
URL:
Keywords:
: 6395 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-12-27 01:24 PST by Maciej Stachowiak
Modified: 2006-01-31 21:20 PST (History)
2 users (show)

See Also:


Attachments
patch that gets a bunch of speedups by passing this stuff for activation objects (9.13 KB, patch)
2006-01-05 23:55 PST, Maciej Stachowiak
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2005-12-27 01:24:09 PST
On my machine, the getter/setter change caused a regression in JavaScript iBench speed from 1980ms or 
so to ~2150ms. After the fix for 6083, it is down to 2020. That's way better, but still a regression.
Comment 1 Darin Adler 2005-12-27 09:56:01 PST
Some of the suggestions in bug 6083 might help.
Comment 2 Maciej Stachowiak 2006-01-05 23:55:49 PST
Created attachment 5509 [details]
patch that gets a bunch of speedups by passing this stuff for activation objects
Comment 3 Maciej Stachowiak 2006-01-05 23:56:15 PST
Also fixes 6249
Comment 4 Maciej Stachowiak 2006-01-05 23:56:36 PST
I meant: Also fixes 6395
Comment 5 Maciej Stachowiak 2006-01-05 23:57:31 PST
*** Bug 6395 has been marked as a duplicate of this bug. ***
Comment 6 Eric Seidel (no email) 2006-01-06 00:11:30 PST
Comment on attachment 5509 [details]
patch that gets a bunch of speedups by passing this stuff for activation objects

Looks good.

You missed an ending newline in the very last file in this patch.
Comment 7 Maciej Stachowiak 2006-01-06 00:32:34 PST
Cc'd Maks, this has some interesting general speedups along the lines of what we talked about as well as 
fixing the slowdown from the getter/setter change.
Comment 8 Alice Liu 2006-01-09 16:27:37 PST
<rdar://problem/4403665>
Comment 9 Joost de Valk (AlthA) 2006-01-22 04:56:26 PST
Removing keyword(s) since bug is fixed.
Comment 10 Joost de Valk (AlthA) 2006-01-22 05:00:47 PST
Removing keyword(s) since bug is fixed.
Comment 11 Eric Seidel (no email) 2006-01-31 21:20:39 PST
Removing Regression keyword from bugs already fixed.